Mercurial > pidgin
view PROGRAMMING_NOTES @ 10787:c932d96a7c69
[gaim-migrate @ 12428]
" Autocorrect in gaim... um... sucks. The problem is
that the correction only happens AFTER you send a
message. This means that you don't actually know what
message you are sending until it is sent. Horrible.
My new patch works AS YOU TYPE with the following rules:
* You must be typing, not pasting in text. If you
paste in the and there is a rule to correct the to the,
it won't be corrected. This is because it would be
impossible to go back and check all the text.
* Check whole words ONLY. Partial words don't count.
* If the dictionary word has capital letters in it,
match only words with that capitalization. (FPT -> FTP
doesn't match ftp.)
* If the dictionary word doesn't have capital letters,
preserve the capitalization the user used. (The code
assumes three possible capitalization schemes:
ALLCAPS, lowercase, and Proper.) Unless the solution
has capital letters. In that case, force the
capitalization used in the solution.
* A word may have quote characters in it and still be a
word.
* If the user immediately hits the backspace key after
a correction, undo the correction." --xkan
" This patch is based off xkahn's work available at:
http://sf.net/support/tracker.php?aid=300235
Most of the changes are his. I just changed his formatting to
match the rest of Gaim more closely. Also, I made a couple
coding style changes.
The two biggest changes I made were:
1) I added some hash stuff to load_config. This removes
duplicates.
2) I imported my list of text replacement strings as the
default list in addition to xkahn's list. My list consisted
primarily of the autocorrect entries from my copy of
OpenOffice.org Writer. There were a few things I've added
by hand. (For those familiar with my comments in #gaim,
this list does NOT include anything like a pwn -> own
replacement. If people want to talk like that, I'm not going to
stop them. This list should be useful to anyone.)
I also fixed a memory leak in load_config. A GtkListStore
stores its own copy of strings, so there is no need to
g_strdup them when appending to the GtkListStore.
When I get a chance, I need to make it give an error if you
try to set a duplicate "You type" word in the preferences.
Otherwise, this patch should take care of everything.
I would recommend considering this patch over xkahn's
because it's a direct superset of his patches. However, I
want to be very clear that most of the changes in this patch
are his and he deserves the credit for them. " --rlaager
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Thu, 07 Apr 2005 14:35:25 +0000 |
parents | da88e2cd5c53 |
children | 83ec0b408926 |
line wrap: on
line source
Notes on keeping GAIM OS independant ------------------------------------ General ------- - Use G_DIR_SEPARATOR_S and G_DIR_SEPARATOR for paths - Use g_getenv, g_snprintf, g_vsnprintf - Use gaim_home_dir instead of g_get_home_dir or g_getenv("HOME") - Make sure when including win32dep.h that it is the last header to be included. - Open binary files when reading or writing with 'b' mode. e.g: fopen("somefile", "wb"); Not doing so will open files in windows using defaut translation mode. i.e. newline -> <CR><LF> Paths ----- - DATADIR, LOCALEDIR & LIBDIR are defined in wingaim as functions. Doing the following will therefore break the windows build: printf("File in DATADIR is: %s\n", DATADIR G_DIR_SEPARATOR_S "pic.png"); it should be: printf("File in DATADIR is: %s%s%s\n", DATADIR, G_DIR_SEPARATOR_S, "pic.png"); PLUGINS & PROTOS ---------------- - G_MODULE_EXPORT all functions which are to be accessed from outside the scope of its "dll" or "so". (E.G. gaim_plugin_init) - G_MODULE_IMPORT all global variables which are located outside your dynamic library. (E.G. connections) (Not doing this will cause "Memory Access Violations" in Win32)