Mercurial > pidgin
view README.CVS @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Sat, 18 Sep 2004 23:17:18 +0000 |
parents | e4a27c9aec4c |
children |
line wrap: on
line source
If you plan to use gaim CVS, PLEASE read this message in its entirety! Gaim is a fast-moving project with a somewhat regular release schedule. Due to the rate of gaim development, CVS undergoes frequent bursts of massive changes, often leaving behind brokenness and partial functionality while the responsible developers rewrite some portion of code or seek to add new features. What this all boils down to is that CVS _WILL_ sometimes be broken. Because of this, we ask that users who are not interested in personally tracking down bugs and fixing them (without a lot of assistance from the developers!) avoid CVS and use releases. Since releases will be made often, this should not prevent anyone from using the newest, shiniest features -- but it will prevent users from having to deal with ugly development bugs that we already know about but haven't gotten around to fixing. If you are interested in hacking on gaim, please read README and HACKING, and take note of the issues in PROGRAMMING_NOTES. (Note that they may be somewhat out of date at times.) Win32 developers, please read README.mingw. By far the best documentation, however, is the documented code. Not all parts of gaim have yet been documented, but the major subsystems are falling fast. If you have doxygen, you can use the Doxyfile in the toplevel directory to generate pretty documentation. Otherwise (or even if you do!), the header files for each subsystem contain documentation for the functions they contain. For instance, conversation.h contains documentation for the entire gaim_conversation_* API, and account.h contains documentation for the gaim_account_* API. If you have questions, please feel free to contact the gaim developers by email at gaim-devel@lists.sourceforge.net, on IRC at irc.freenode.net in #gaim, or via the sourceforge forums at http://www.sourceforge.net/projects/gaim. Please do as much homework as you can before contacting us; the more you know about your question, the faster and more effectively we can help you! Send patches to gaim-devel@lists.sourceforge.net or post them in the Sourceforge forums at http://www.sourceforge.net/projects/gaim.