Mercurial > pidgin
view src/protocols/oscar/faimconfig.h @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Sat, 18 Sep 2004 23:17:18 +0000 |
parents | d82efea341ef |
children |
line wrap: on
line source
/* * faimconfig.h * * Contains various compile-time options that apply _only_ to libfaim. * */ #ifndef __FAIMCONFIG_H__ #define __FAIMCONFIG_H__ /* * USE_SNAC_FOR_IMS is an old feature that allowed better * tracking of error messages by caching SNAC IDs of outgoing * ICBMs and comparing them to incoming errors. However, * its a helluvalot of overhead for something that should * rarely happen. * * Default: defined. This is now defined by default * because it should be stable and its not too bad. * And Josh wanted it. * */ #define USE_SNAC_FOR_IMS /* * Default Authorizer server name and TCP port for the OSCAR farm. * * You shouldn't need to change this unless you're writing * your own server. * * Note that only one server is needed to start the whole * AIM process. The later server addresses come from * the authorizer service. * * This is only here for convenience. Its still up to * the client to connect to it. * */ #define FAIM_LOGIN_SERVER "login.oscar.aol.com" #define FAIM_LOGIN_PORT 5190 /* * Size of the SNAC caching hash. * * Default: 16 * */ #define FAIM_SNAC_HASH_SIZE 16 /* * If building on Win32, define WIN32_STATIC if you don't want * to compile libfaim as a DLL (and instead link it right into * your app). */ #define WIN32_STATIC #endif /* __FAIMCONFIG_H__ */