Mercurial > pidgin
view src/imgstore.c @ 7751:d691cb95ee67
[gaim-migrate @ 8396]
Changes for the conversation "Find" dialog:
-Makes the window manager "X" work correctly when closing the dialog
-Added an "s" mnemonic for the search box
-Hitting enter now performs the default action (Find)
-The Find button grays and un-grays (aka sensitizes and desensitizes)
itself based on the presence or absence of text in the search box.
For this I moved a function from dialogs.c to util.[c|h]:
gaim_gtk_set_sensitive_if_input()
-HIGification suggestions from Steven Garrity:
1. Give the window a title ("Find") as is recommended by the HIG
(http://developer.gnome.org/projects/gup/hig/1.0/windows.html#window-properties).
2. Drop the phrase "Enter a search phrase" altogether. Since the text
box is already labeled (and if the window was labeled too), this phrase
is redundant. Removing it simplifies the visual appearance of the
window, and is one less thing to translate.
3.Change text box label from "Search term:" to "Search for:". This isn't
a big deal, but the Search window in GEdit uses "Search for:" (I
couldn't find much consistency anywhere else).
4.Move "Close" and "Find" buttons to be 12 pixels from the bottom and
right edges of the window, as recommended by the HIG
(http://developer.gnome.org/projects/gup/hig/1.0/layout.html#window-layout-spacing).
Also thanks to Nathan Fredrickson for writing a patch for Steven's
suggestions.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Dec 2003 22:09:58 +0000 |
parents | 083d1e4a9c78 |
children | fa6395637e2c |
line wrap: on
line source
/** * @file imgstore.h IM Image Store API * @ingroup core * * gaim * * Copyright (C) 2003 Robert McQueen <robot101@debian.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include <glib.h> #include <debug.h> #include <imgstore.h> static GSList *imgstore = NULL; static int nextid = 0; typedef struct { int id; int refcount; GaimStoredImage *img; } GaimStoredImagePriv; /* private functions */ static GaimStoredImagePriv *gaim_imgstore_get_priv(int id) { GSList *tmp = imgstore; GaimStoredImagePriv *priv = NULL; g_return_val_if_fail(id > 0, NULL); while (tmp && !priv) { GaimStoredImagePriv *tmp_priv = tmp->data; if (tmp_priv->id == id) priv = tmp_priv; tmp = tmp->next; } if (!priv) gaim_debug(GAIM_DEBUG_ERROR, "imgstore", "failed to find image id %d\n", id); return priv; } static void gaim_imgstore_free_priv(GaimStoredImagePriv *priv) { GaimStoredImage *img = NULL; g_return_if_fail(priv != NULL); img = priv->img; if (img) { if (img->data) g_free(img->data); if (img->filename) g_free(img->filename); g_free(img); } gaim_debug(GAIM_DEBUG_INFO, "imgstore", "freed image id %d\n", priv->id); g_free(priv); imgstore = g_slist_remove(imgstore, priv); } /* public functions */ int gaim_imgstore_add(const void *data, size_t size, const char *filename) { GaimStoredImagePriv *priv; GaimStoredImage *img; g_return_val_if_fail(data != NULL, 0); g_return_val_if_fail(size > 0, 0); img = g_new0(GaimStoredImage, 1); img->data = g_memdup(data, size); img->size = size; img->filename = g_strdup(filename); priv = g_new0(GaimStoredImagePriv, 1); priv->id = ++nextid; priv->refcount = 1; priv->img = img; imgstore = g_slist_append(imgstore, priv); gaim_debug(GAIM_DEBUG_INFO, "imgstore", "added image id %d\n", priv->id); return priv->id; } GaimStoredImage *gaim_imgstore_get(int id) { GaimStoredImagePriv *priv = gaim_imgstore_get_priv(id); g_return_val_if_fail(priv != NULL, NULL); gaim_debug(GAIM_DEBUG_INFO, "imgstore", "retrieved image id %d\n", priv->id); return priv->img; } void gaim_imgstore_ref(int id) { GaimStoredImagePriv *priv = gaim_imgstore_get_priv(id); g_return_if_fail(priv != NULL); (priv->refcount)++; gaim_debug(GAIM_DEBUG_INFO, "imgstore", "referenced image id %d (count now %d)\n", priv->id, priv->refcount); } void gaim_imgstore_unref(int id) { GaimStoredImagePriv *priv = gaim_imgstore_get_priv(id); g_return_if_fail(priv != NULL); g_return_if_fail(priv->refcount > 0); (priv->refcount)--; gaim_debug(GAIM_DEBUG_INFO, "imgstore", "unreferenced image id %d (count now %d)\n", priv->id, priv->refcount); if (priv->refcount == 0) gaim_imgstore_free_priv(priv); }