Mercurial > pidgin
view libpurple/protocols/msn/history.c @ 24532:d70eb6304eae
Use separate variables to keep track of the timer and the watcher.
I believe only one of these will be used at any given time, and so
while there is no overlap in their usage we need to use different
variables so that we can call either purple_input_remove or
purple_timeout_remove depending on the usage. I don't think this
matters with glib because purple_input_remove and
purple_timeout_remove both call g_source_remove, but it could be
an issue when using other event loops.
There's also the problem in line 673 where we add the watcher, but
then if the call to msn_soap_write_cb fails we add a timer using
the same variable. That's still going to be a little buggy.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Tue, 25 Nov 2008 02:43:56 +0000 |
parents | 723b5a2f91ce |
children | 7492ddb953fd |
line wrap: on
line source
/** * @file history.c MSN history functions * * purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #include "msn.h" #include "history.h" MsnHistory * msn_history_new(void) { MsnHistory *history = g_new0(MsnHistory, 1); history->trId = 1; history->queue = g_queue_new(); return history; } void msn_history_destroy(MsnHistory *history) { MsnTransaction *trans; while ((trans = g_queue_pop_head(history->queue)) != NULL) msn_transaction_destroy(trans); g_queue_free(history->queue); g_free(history); } MsnTransaction * msn_history_find(MsnHistory *history, unsigned int trId) { MsnTransaction *trans; GList *list; for (list = history->queue->head; list != NULL; list = list->next) { trans = list->data; if (trans->trId == trId) return trans; } return NULL; } void msn_history_add(MsnHistory *history, MsnTransaction *trans) { GQueue *queue; g_return_if_fail(history != NULL); g_return_if_fail(trans != NULL); queue = history->queue; trans->trId = history->trId++; g_queue_push_tail(queue, trans); if (queue->length > MSN_HIST_ELEMS) { trans = g_queue_pop_head(queue); msn_transaction_destroy(trans); } }