Mercurial > pidgin

view AUTHORS @ 22411:d9105ead88dc

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
When purple_buddy_icons_set_account_icon() is called, it unrefs the old PurpleStoredImage and refs the new one. Previously, it notified the prpl of the change in the buddy icon before updating pointer_icon_cache, which meant that if the prpl then called purple_buddy_icons_find_account_icon() it would get the old PurpleStoredImage (which is at this point not only old but also a pointer to invalid memory if unref'ing it caused it to be destroyed). This happens in jabber_set_info() as of 2.4.0, causing a crash when setting no-buddy-icon for an account after it has previously had an icon. I think this also means that XMPP accounts in 2.4.0 will also always set serverside the *last* icon set, not the current one, when changing icons, but I didn't test that. The solution is simple: Update pointer_icon_cache earlier, setting the new img if there is one or removing the account entirely from the hash table if there isn't one now. This fixes both problems described above, making purple_buddy_icons_find_account_icon() return the new, current icon (or NULL) at all times.
author Evan Schoenberg <evan.s@dreskin.net>
date Tue, 04 Mar 2008 00:11:22 +0000
parents 0abfc065cf77
children 395ced2d98cc
line wrap: on
line source

Pidgin and Finch: The Pimpin' Penguin IM Clients That're Good for the Soul
==========================================================================

For a complete list of all contributors, see the COPYRIGHT file.

We've got an IRC room now too, #pidgin on irc.freenode.net. Come check us out.

Current Developers:
------------------

Sean Egan <seanegan@gmail.com> - Lead Developer
	AIM: SeanEgn
	ICQ: 96642211
	Yahoo:	SeanEgn
	MSN:  seanegn@hotmail.com
	XMPP:  seanegn@jabber.org
	Gadu-Gadu:  1511497

Daniel 'datallah' Atallah - Developer
John 'rekkanoryo' Bailey - Developer
Ethan 'Paco-Paco' Blanton - Developer
Thomas Butter - Developer
Ka-Hing Cheung - Developer
Sadrul Habib Chowdhury - Developer
Mark 'KingAnt' Doliner - Developer
Casey Harkins - Developer
Gary 'grim' Kramlich - Developer
Richard 'rlaager' Laager - Developer
Richard 'wabz' Nelson - Developer
Christopher 'siege' O'Brien - Developer
Bartosz Oler - Developer
Etan 'deryni' Reisner - Developer
Tim 'marv' Ringenbach - Developer
Luke 'LSchiere' Schierer - Support
Megan 'Cae' Schneider - support/QA
Evan Schoenberg - Developer
Kevin 'SimGuy' Stange - Developer & Webmaster
Will 'resiak' Thompson - Developer
Stu 'nosnilmot' Tomlinson - Developer
Nathan 'faceprint' Walp - Developer

Crazy Patch Writers:
-------------------
Dennis 'EvilDennisR' Ristuccia
Peter 'Fmoo' Ruibal
Elliott 'QuLogic' Sales de Andrade
Gabriel 'Nix' Schulhof

Retired Developers:
------------------
Herman Bloggs - Win32 Port
Jim Duchek <jim@linuxpimps.com> - maintainer
Rob Flynn <gaim@robflynn.com> - maintainer
Adam Fritzler - libfaim maintainer
Christian 'ChipX86' Hammond - Developer & Webmaster
Syd Logan - hacker and designated driver [lazy bum]
Jim Seymour - XMPP developer
Mark Spencer <markster@marko.net> - original author
Eric Warmenhoven <eric@warmenhoven.org> - lead developer

Retired Crazy Patch Writers:
---------------------------
Felipe 'shx' Contreras
Decklin Foster
Peter 'Bleeter' Lawler
Robert 'Robot101' McQueen
Benjamin Miller

Artists:
-------
Hylke Bons - Icons

Other Contributions:
-------------------
Much thanks to Evan Martin <martine@cs.washington.edu> for writing 
GtkSpell <http://gtkspell.sourceforge.net> responsible for the 
"Highlight misspelled words" feature and for gtk-nativewin
<http://bunny.darktech.org/cvs/gtk-nativewin/> the default GTK+-2.0
engine originally used in our win32 port.

** ORIGINAL LOGO DESIGNED BY: Naru Sundar **

Peter Teichiman <peter@helixcode.com>
Larry Ewing 
Jeramey A. Crawford
	Thanks to these boys.  Peter and Larry managed to stomp
	out a large list of Mem Leaks.  Jeramey found the remaining
	onees and pointed me to those.  Props to the boys at 
	Helix Code.  Thanks guys.

Nathan Walp
	A healthy amount of patches for the Jabber plugin

Neil Sanchala
	Wrote most of the Zephyr plugin

Arkadiusz Miskiewicz
	Wrote the Gadu-Gadu plugin
	
David Prater    <IM: dRaven43>          draven@tcsx.net   
	Log and Colour Button Images

Sébastien Carpe <IM: Seb Carpe>
	Base HTTP Proxy Support

Ari Pollak      <IM: Ari Pollak>	compwiz.dhs.org
	Resize conversation window patch   

Decklin Foster
	Many GUI improvements, other nifty additions and fixes

David <IM: CrazyDavy>
	The neato-bigger text box

S D Erle
	Writing a cool perl script to translate WinAIM lists to gaim

BMiller
	A good collection of stuff. %n for away messages, import winaim
	lists, pic/text/pic+text for buttons, among others

Lance Rocker
	Improved HTML formatting in logs, plus lots of debugging on *BSD.

ergofobe:
	GNOME Url handler patch

Justin M. Ward <justin@yossman.net>:
	Alphabetical Away Messages patch

G. Sumner Hayes <IM: SumnerFool> Security Patches

Brian Ryner for a little make file patch :)

Ryan C. Gordon - I still think you look like Silent Bob.

Elliot Tobin <elliot@bha.udel.edu>

Thanks to Jeroen van der Vegt for the initial smiley plugin and images.

The OpenQ Team
	Wrote the QQ plugin (see AUTHORS in the qq directory)