view .mtn-ignore @ 22403:dfe4a3e3336a

serv_got_joined_chat() emits "chat-joined" but it also calls purple_conversation_new() which emits "conversation-created", so attaching to both signals would make create_conv and attach_signals to be called twice, leaking the list of signal ids: ==30871== 67 (43 direct, 24 indirect) bytes in 3 blocks are definitely lost in loss record 94 of 265 ==30871== at 0x4006A6E: malloc (vg_replace_malloc.c:207) ==30871== by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6) ==30871== by 0xA31B3A: g_slice_alloc (in /lib/libglib-2.0.so.0.1400.6) ==30871== by 0xA32D9A: g_slist_append (in /lib/libglib-2.0.so.0.1400.6) ==30871== by 0x4F1CA4A: attach_signals (notify.c:321) ==30871== by 0x4F1CDCA: conv_created (notify.c:388) Credit goes to Andrew Gaul for sending me this valgrind trace, blame me if this breaks anything.

(.*/)?\.svn
.*/?Makefile(\.in)?$
(.*/)?TAGS$
.*/?.*\.pc$
.*/perl/common/[^/]+\.c$
.*/perl/common/blib.*
.*/perl/common/pm_to_blib$
.*\.bs$
.*\.def$
.*\.dll$
.*\.exe$
intltool-.*
Doxyfile(\.mingw)?$
aclocal.m4
compile
config.cache
config.guess
config.h$
config.h.in
config.log
config.status
config.sub
configure$
finch/finch$
finch/libgnt/gntmarshal.c
finch/libgnt/gntmarshal.h
depcomp
doc/finch.1$
doc/pidgin.1$
doc/html
pidgin.apspec$
pidgin.desktop$
pidgin.spec$
pidgin-.*.tar.gz
pidgin-.*.tar.bz2
pidgin-*.*.*-win32bin$
pidgin/pidgin$
pidgin/pixmaps/emotes/default/24/theme
pidgin/pixmaps/emotes/none/theme
pidgin/plugins/musicmessaging/music-messaging-bindings.c
pidgin/plugins/perl/common/Makefile.PL$
pidgin/win32/pidgin_dll_rc.rc$
pidgin/win32/pidgin_exe_rc.rc$
install-sh
libpurple/dbus-bindings.c
libpurple/dbus-types.c
libpurple/dbus-types.h
libpurple/example/nullclient
libpurple/gconf/purple.schemas$
libpurple/plugins/dbus-example-bindings.c
libpurple/plugins/perl/common/Makefile.PL$
libpurple/plugins/perl/common/const-c.inc
libpurple/plugins/perl/common/const-xs.inc
libpurple/plugins/perl/common/lib
libpurple/purple.h$
libpurple/purple-client-bindings.c
libpurple/purple-client-bindings.h
libpurple/purple-client-example
libpurple/tests/check_libpurple
libpurple/version.h$
libpurple/win32/libpurplerc.rc$
libtool
local.mak
ltmain.sh
missing
mkinstalldirs
po/Makefile.in.in
po/POTFILES$
po/missing
po/notexist
po/pidgin.pot
po/stamp-it
stamp-h1
win32-install-dir(\.release)?
VERSION$