Mercurial > pidgin
view libpurple/version.c @ 22403:dfe4a3e3336a
serv_got_joined_chat() emits "chat-joined" but it also calls
purple_conversation_new() which emits "conversation-created", so attaching
to both signals would make create_conv and attach_signals to be called twice,
leaking the list of signal ids:
==30871== 67 (43 direct, 24 indirect) bytes in 3 blocks are definitely lost in loss record 94 of 265
==30871== at 0x4006A6E: malloc (vg_replace_malloc.c:207)
==30871== by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0xA31B3A: g_slice_alloc (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0xA32D9A: g_slist_append (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0x4F1CA4A: attach_signals (notify.c:321)
==30871== by 0x4F1CDCA: conv_created (notify.c:388)
Credit goes to Andrew Gaul for sending me this valgrind trace, blame me if
this breaks anything.
author | Ka-Hing Cheung <khc@hxbc.us> |
---|---|
date | Mon, 03 Mar 2008 07:03:54 +0000 |
parents | 6bf32c9e15a7 |
children | eb2e2585f917 |
line wrap: on
line source
/* * @file version.c Version Functions * @ingroup core */ /* Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #include "internal.h" #include "version.h" const guint purple_major_version = PURPLE_MAJOR_VERSION; const guint purple_minor_version = PURPLE_MINOR_VERSION; const guint purple_micro_version = PURPLE_MICRO_VERSION; const char *purple_version_check(guint required_major, guint required_minor, guint required_micro) { if (required_major > PURPLE_MAJOR_VERSION) return "libpurple version too old (major mismatch)"; if (required_major < PURPLE_MAJOR_VERSION) return "libpurple version too new (major mismatch)"; if (required_minor > PURPLE_MINOR_VERSION) return "libpurple version too old (minor mismatch)"; if ((required_minor == PURPLE_MINOR_VERSION) && (required_micro > PURPLE_MICRO_VERSION)) return "libpurple version too old (micro mismatch)"; return NULL; }