Mercurial > pidgin
view src/stringref.c @ 12115:e9790eb93216
[gaim-migrate @ 14415]
quoth charkins:
" This patch has a few small fixes for the visibility
stuff in gtkblist.c.
First, tracking of the ICONIFIED state of the blist was
removed. This was intended to allow the blist to
"remember" if it was minimized between restarts.
Unfortunately, this is not possible because the
ICONIFIED state gets set when the blist is on a
different desktop with many window managers.
Second, while talking about the ICONIFIED issue on
#gtk@GIMPNet, muntyan_ asked about a bug where the
blist would get shown on an account re-connect with
1.5.0. Luke mentioned something about this with cvs as
well. This patch introduces a check in
gaim_gtk_blist_show() to prevent the window from being
shown if it already exists and is visible.
Third, sadrul pointed me to a one-line fix for the
missing blist on startup. I added a second line to make
sure the blist restores its proper size as well.
Finally, when the last visibility manager is removed,
gaim will now minimize the blist if it was previously
hidden, rather than showing it. This could prevent a
race condition with out-of-process applets, preventing
gaim from maintaining the visibility state properly
between restarts.
This was 'cvs diff'ed against the last available anon
cvs from Friday. Hopefully it'll apply cleanly."
it did.
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Wed, 16 Nov 2005 17:55:26 +0000 |
parents | ceb88c0a1abb |
children |
line wrap: on
line source
/** * @file stringref.c Reference-counted immutable strings * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include "internal.h" #include <string.h> #include <stdarg.h> #include "debug.h" #include "stringref.h" #define REFCOUNT(x) ((x) & 0x7fffffff) static GList *gclist = NULL; static void stringref_free(GaimStringref *stringref); static gboolean gs_idle_cb(gpointer data); GaimStringref *gaim_stringref_new(const char *value) { GaimStringref *newref; if (value == NULL) return NULL; newref = g_malloc(sizeof(GaimStringref) + strlen(value)); strcpy(newref->value, value); newref->ref = 1; return newref; } GaimStringref *gaim_stringref_new_noref(const char *value) { GaimStringref *newref; if (value == NULL) return NULL; newref = g_malloc(sizeof(GaimStringref) + strlen(value)); strcpy(newref->value, value); newref->ref = 0x80000000; if (gclist == NULL) g_idle_add(gs_idle_cb, NULL); gclist = g_list_prepend(gclist, newref); return newref; } GaimStringref *gaim_stringref_printf(const char *format, ...) { GaimStringref *newref; va_list ap; if (format == NULL) return NULL; va_start(ap, format); newref = g_malloc(sizeof(GaimStringref) + g_printf_string_upper_bound(format, ap)); vsprintf(newref->value, format, ap); va_end(ap); newref->ref = 1; return newref; } GaimStringref *gaim_stringref_ref(GaimStringref *stringref) { if (stringref == NULL) return NULL; stringref->ref++; return stringref; } void gaim_stringref_unref(GaimStringref *stringref) { if (stringref == NULL) return; if (REFCOUNT(--(stringref->ref)) == 0) { if (stringref->ref & 0x80000000) gclist = g_list_remove(gclist, stringref); stringref_free(stringref); } } const char *gaim_stringref_value(const GaimStringref *stringref) { return (stringref == NULL ? NULL : stringref->value); } int gaim_stringref_cmp(const GaimStringref *s1, const GaimStringref *s2) { return (s1 == s2 ? 0 : strcmp(gaim_stringref_value(s1), gaim_stringref_value(s2))); } size_t gaim_stringref_len(const GaimStringref *stringref) { return strlen(gaim_stringref_value(stringref)); } static void stringref_free(GaimStringref *stringref) { #ifdef DEBUG if (REFCOUNT(stringref->ref) != 0) { gaim_debug(GAIM_DEBUG_ERROR, "stringref", "Free of nonzero (%d) ref stringref!\n", REFCOUNT(stringref->ref)); return; } #endif /* DEBUG */ g_free(stringref); } static gboolean gs_idle_cb(gpointer data) { GaimStringref *ref; GList *del; while (gclist != NULL) { ref = gclist->data; if (REFCOUNT(ref->ref) == 0) { stringref_free(ref); } del = gclist; gclist = gclist->next; g_list_free_1(del); } return FALSE; }