Mercurial > pidgin
view TODO @ 12645:fc28451f5d96
[gaim-migrate @ 14983]
SF Patch #1314512 from Sadrul (who has a patch for everything)
"This patch introduces a flag for protocol plugins that
support offline messages (like Y!M and ICQ). This was
encouraged by the following conversation:
<sadrul> should offline buddies be listed/enabled in
the send-to menu?
<rekkanoryo> i would think only for protocols that
support offline messaging, if it's indicated that the
buddy is offline
-- <snip> --
<Bleeter> sadrul: personally, I'd like to see a
'supports offline' flag of some description
<Bleeter> one could then redirect (via plugins) through
email or alternative methods
<Bleeter> just a thought
<Paco-Paco> yeah, that sounds like a reasonble thing to have
This patch uses this flag to disable the buddies in the
send-to menu who are offline and the protocol doesn't
support offline messages."
I made this make the label insensitive instead of the whole menuitem. This
should address SimGuy's concerns about inconsistency (i.e. you could create a
conversation with someone via the buddy list that you couldn't create via the
Send To menu). I also hacked up some voodoo to show the label as sensitive when
moused-over, as that looks better (given the label-insensitive thing is itself a
hack). I think this works quite well.
BUG NOTE:
This makes more obvious an existing bug. The Send To menu isn't updated when
buddies sign on or off or change status (at least under some circumstances).
We need to fix that anyway, so I'm not going to let it hold up this commit.
Switching tabs will clear it up. I'm thinking we just might want to build the
contents of that menu when it is selected. That would save us a mess of
inefficient signal callbacks that update the Send To menus in open windows all
the time.
AIM NOTE:
This assumes that AIM can't offline message. That's not strictly true. You can
message invisible users on AIM. However, by design, we can't tell when a user
is invisible without resorting to dirty hackery. In practice, this isn't a
problem, as you can still select the AIM user from the menu. And really, how
often will you be choosing the Invisible contact, rather than the user going
Invisible in the middle of a conversation or IMing you while they're Invisible?
JABBER NOTE:
This assumes that Jabber can always offline message. This isn't strictly true.
Sadrul said:
I have updated Jabber according to this link which seems to
talk about how to determine the existence offline-message
support in a server:
http://www.jabber.org/jeps/jep-0013.html#discover
However, jabber.org doesn't seem to send the required
info. So I am not sure about it.
He later said:
I talked to Nathan and he said offline message support is
mostly assumed for most jabber servers. GTalk doesn't yet
support it, but they are working on it. So I have made
jabber to always return TRUE.
If there is truly no way to detect offline messaging capability, then this is
an acceptable solution. We could special case Google Talk because of its
popularity, and remove that later. It's probably not worth it though.
MSN NOTE:
This assumes that MSN can never offline message. That's effectively true, but
to be technically correct, MSN can offline message if there's already a
switchboard conversation open with a user. We could write an offline_message
function in the MSN prpl to detect that, but it'd be of limited usefulness,
especially given that under most circumstances (where this might matter), the
switchboard connection will be closed almost immediately.
CVS NOTE:
I'm writing to share a tragic little story.
I have a PC that I use for Gaim development. One day, I was writing a commit
message on it, when all of a suddent it went berserk. The screen started
flashing, and the whole commit message just disappeared. All of it. And it was
a good commit message! I had to cram and rewrite it really quickly. Needless to
say, my rushed commit message wasn't nearly as good, and I blame the PC for that.
Seriously, though, what kind of version control system loses your commit
message on a broken connection to the server? Stupid!
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Fri, 23 Dec 2005 19:26:04 +0000 |
parents | 99548d90257e |
children | 134e570b3688 |
line wrap: on
line source
* conversation api {{{ * need to handle: {{{ * unnamed chats * chats with the same name as a buddy * this should be working now, but it needs to be kept in mind when (re-)designing * jabber Messages (one off messages vrs a conversation with a backlog) * multiple conversations with a single buddy (jabber, with thread tag) * bugs }}} * notes: {{{ * (12:58:39) Robot101: user list always|auto|never * topic only where supported by the protocol * how do we log this? {{{ * rlaager's (NEW) proposal: {{{ * each conversation has 1 or more logs associated with it. * when someone joins, a new log is opened * file based loggers should try to use hard-links in a smart way to avoid duplicating data on disk as much as possible... * this needs to be designed in such a way that a database logger can handle it w/o duplication... * TO SOLVE THESE CONCERNS, a link and/or copy function callback will likely need to be added }}} }}} }}} }}} * buddy list {{{ * we have not committed any gobjectification, so this is not a blocker for 2.0.0 until we do. * if we do, it is only a blocker to the extent that gaim needs to run. That is, we do not *necessarily* have to gobjectifiy everything as long as we preserve functionality. * That being said, my understanding of the signals mess says that it is probly more work to try to do this in stages than to start it or not start it. * This would require some sort of signal aggregation, as gobject signals are unique to the instance. * one way to do this would be to emit the signals from a non-descript buddy object. this would most closely mimic the current functionality * a second way would be to actually try to aggregate them in some way. I really don't know how possible this is, but it would allow us to do things like set a pounce on everyone in a group or define sounds on a per-group basis. * we could look at replacing the UI ops with signals/call backs * bugs * buddy shows as group on add until gaim restart * buddy shows as online when offline * buddy shows as offline when online * wrong buddy given priority * so on and so forth }}} * build targets {{{ * this is not a blocker * we need build targets for libgaim, we need to test them, and make sure they work. * we ought to use our own build targets to build the executable itself. * due to the limitations of cvs, this cannot accompany moving files to other directories at this time. }}} * status {{{ * Sean's segment of the UI needs to be finished. We need to have support for the (new) default case of one global status at all times. we currently do not, unless that happens to be "online/present" * Tim's modifications to Sean's ui should be included to allow exceptions. refer to gaim-devel archives for this. }}} * account editor {{{ * this is not a blocker for 2.0.0 * account editor is not intuitive, users do not find it. * Luke: my temptation is to get rid of this entirely, in favor of deryni's account menu. {{{ * at this point, tools->accounts is only used for add/delete account, modify account, and enable account. * most users do not have the 15+ accounts that some gaim developers do. a menu scales well for anything from 2 to n, n "small" accounts. * this would allow ready access to the buddy icon stuff, and account actions could go here * status is handled as per the new api, status stuff need not go here beyond enabled. * the account modify dialog is already too big. this would let us split it, for instance buddy icon need not be in it this way. Similarly, alias need not be in it. * splitting the account modify dialog to tabs seems to work nicely. Still, I think that the menu would be nicer. }}} }}} * Privacy {{{ * this is not a blocker for 2.0.0 * Privacy sucks. it doesn't handle many of the protocols in a way that users understand. notably msn, but also yahoo, jabber, and icq. * We want to sync to the server as much as possible, entirely local-only privacy is not an option except on protocols like irc that have no server-side. * We want to be as consistent across protocols as possible. this will require renaming things on some protocols. * Bleeter suggests that we create a privacy.xml, remove privacy from blist.xml. He suggests that each protocol define certain capabilities & defaults, with accounts.xml holding exceptions to the defaults. }}} * Perl {{{ * Block for 2.0.0 or remove perl: * Summer of Code seems to have largely solved this. * Extended testing and resolving the inevitable bugs remains. * Test each call to make sure it actually works * Make it work with G_MODULE_BIND_LOCAL }}} * Prefs {{{ * this blocks for 2.0.0 * Prefs cannot stay as-is. the dialog is far too wide and not at all usable. * The biggest problem is that each new plugin creates horizontal space. {{{ * I do not see it as a solution to remove the posability of plugin preferences. * In the past, we had a separate plugin management dialog. People never found it, and were often surprised to learn that gaim had plugins at all. I am unsure that people find the current plugin page of preferences any more frequently, but I *suspect* that it is the case. This leads to a conundrum, how do plugins display preferences? }}} * Currently the window is, at my font size, 1129x505 (or should that be 505x1129?). It *should* fit in 800x600 at worst, I'm unsure that 480x640 is a reasonable goal. still, this leaves us with something either considerably wider or considerably taller than we are currently using (on any given pane, the tabs force the width, not the contents). Further, taking "Message Text" as an example, it has 3 preferences and a text area, each in its own category (the text area sharing a category with 1 preference). obvious waste of space here. All 3 could clearly be uncategorised without loss of meaning, categories only make sense for groups of preferences. It may even be possible to combine this with "Conversations" entirely. }}}