Mercurial > pidgin

log libpurple/buddyicon.c @ 22789:4457e6a99d13

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
less more | (0) -60 tip
age author description
Fri, 04 Apr 2008 04:42:26 +0000 Mark Doliner Documentation changes
Thu, 03 Apr 2008 23:51:19 +0000 Mark Doliner Better documentation.
Tue, 04 Mar 2008 23:53:44 +0000 Evan Schoenberg Just write out the buddy icon file; there's no need to check to see if it exists. This is for the cache, and if the blist.xml gets out of sync with the cache on disk (for example, because the user moves the blist.xml file out of the way), the existing code will never update the cached icon again.
Tue, 04 Mar 2008 00:11:22 +0000 Evan Schoenberg When purple_buddy_icons_set_account_icon() is called, it unrefs the old PurpleStoredImage and refs the new one. Previously, it notified the prpl of the change in the buddy icon before updating pointer_icon_cache, which meant that if the prpl then called purple_buddy_icons_find_account_icon() it would get the old PurpleStoredImage (which is at this point not only old but also a pointer to invalid memory if unref'ing it caused it to be destroyed). This happens in jabber_set_info() as of 2.4.0, causing a crash when setting no-buddy-icon for an account after it has previously had an icon. I think this also means that XMPP accounts in 2.4.0 will also always set serverside the *last* icon set, not the current one, when changing icons, but I didn't test that.
Sun, 03 Feb 2008 19:43:41 +0000 John Bailey Kill off gc->prpl in the core everywhere but connection.c (when the struct
Wed, 23 Jan 2008 05:16:39 +0000 Sadrul Habib Chowdhury We need to store the img in the hashtable only after we have removed the old
Tue, 08 Jan 2008 22:01:22 +0000 Evan Schoenberg merge of '5d18b4aee9c05f592af532f9155aadb23ad11d4b'
Tue, 08 Jan 2008 03:02:08 +0000 Stu Tomlinson Apparently "nil" is an Objective-C thing
Tue, 08 Jan 2008 21:58:31 +0000 Evan Schoenberg If the UI sets a cache directory before purple_buddy_icons_init() is called
Tue, 08 Jan 2008 02:47:51 +0000 Evan Schoenberg There's nothing wrong with calling purple_buddy_icons_find() can not receiving an icon in return - it just means that no icon was found. We shouldn't attempt to call purple_buddy_icon_ref() on NULL, which will trigger a failed assertion.
Mon, 07 Jan 2008 23:20:40 +0000 Evan Schoenberg Remove spurious braces
Mon, 07 Jan 2008 09:14:39 +0000 Sadrul Habib Chowdhury compile
Mon, 07 Jan 2008 00:32:26 +0000 Evan Schoenberg If the cached buddy icon can't be loaded, delete the preferences which point to it. Among other things, this fixes OSCAR buddy icon retrieval when the cache has been removed - since previously the icon hash was kept around and was used to determine that (so far as the prpl could tell) no icon retrieval was needed, libpurple would never have an icon for the contact.
Fri, 04 Jan 2008 21:30:24 +0000 Daniel Atallah We can't rely on g_strerror() being set by g_file_test().
Mon, 17 Dec 2007 07:29:39 +0000 Sean Egan Patch from eperez to make writing to buddy icon files atomic. Fixes #3528.
Mon, 19 Nov 2007 07:44:51 +0000 Ka-Hing Cheung prpl->set_buddy_icon may keep a reference to PurpleStoredImage, move the
Sat, 03 Nov 2007 17:52:28 +0000 Nathan Walp replace most calls to strerror with calls to g_strerror. strerror will return
Sun, 21 Oct 2007 04:49:59 +0000 Luke Schierer applied changes from 3ae1e4b3dac8092886b4b8ab961d8d505433b4c4
Sun, 16 Sep 2007 01:05:22 +0000 Sean Egan remove gpl boilerplate from doxygen docs
Sat, 08 Sep 2007 03:09:35 +0000 John Bailey The FSF changed its address a while ago; our files were out of date.
Sat, 16 Jun 2007 19:00:35 +0000 Richard Laager disapproval of revision '1411afd7660760db59966c3a9f18e2adab8eb27e'
Thu, 07 Jun 2007 04:22:42 +0000 Richard Laager Mark the return type const for the following functions. I noticed this
Mon, 04 Jun 2007 05:47:06 +0000 Richard Laager A patch from David Grohmann (dave1g) to log embedded images.
Wed, 09 May 2007 19:05:19 +0000 Richard Laager Patch from ticket #819 from vampire
Fri, 04 May 2007 04:51:19 +0000 Richard Laager Fix a reference counting bug.
Thu, 03 May 2007 23:23:44 +0000 Richard Laager merge of 'df3320af10ba54cf6129f203dedb82f35baf6800'
Thu, 03 May 2007 17:50:36 +0000 Evan Schoenberg Protect icon with ref/unref guards since it may be freed over the course of the while() loop. I thought this would fix #398, but something else is wrong, too.
Thu, 03 May 2007 17:43:07 +0000 Sadrul Habib Chowdhury Remove two warnings, one compile-time, one runtime. Plug two leaks, both runtime.
Thu, 03 May 2007 21:57:49 +0000 Richard Laager Rework purple_buddy_icons_find() to return a reference for the caller, which
Thu, 03 May 2007 07:55:32 +0000 Mark Doliner Change a few functions to free a linked list while iterating through
Mon, 30 Apr 2007 07:03:10 +0000 Mark Doliner Get rid of two harmless warnings:
Sun, 29 Apr 2007 23:34:04 +0000 Richard Laager Document the image-deleting signal.
Sun, 29 Apr 2007 19:46:53 +0000 Sadrul Habib Chowdhury This gets rid of a g_log error when uncache-ing a NULL file.
Sun, 29 Apr 2007 07:03:50 +0000 Richard Laager The GNOME coding guidelines recommend prefixing internal symbols with an underscore.
Sun, 29 Apr 2007 03:46:25 +0000 Richard Laager merge of '2c12ac5fe6f8c8bf07d7bdde347e65c66e4f2de5'
Sun, 29 Apr 2007 03:35:04 +0000 Richard Laager Add more error checking to the buddy icon migration code.
Sun, 29 Apr 2007 02:49:23 +0000 Richard Laager Fix a crash when removing a per-account icon. Here's my explanation:
Sun, 29 Apr 2007 01:17:40 +0000 Daniel Atallah merge of '2d00dcb7fc18b083ac949b5febda711ecfd52cdb'
Sun, 29 Apr 2007 01:08:25 +0000 Richard Laager merge of '833c9b8a7ffaa6f0c0f194a0c73d46d0ec0a64e2'
Sun, 29 Apr 2007 01:04:19 +0000 Richard Laager The OSCAR timestamp stuff.
Sun, 29 Apr 2007 01:10:48 +0000 Daniel Atallah merge of '8bc9a8784cf40932a34e08e80f0d6585812b985a'
Sun, 29 Apr 2007 01:10:33 +0000 Daniel Atallah Fix assertion when creating a new account.
Sun, 29 Apr 2007 00:09:27 +0000 Richard Laager 19:00:43 Ka-Hing Cheung (khc): rlaager: shouldn't we give g_free as the key free function for icon_data_cache?
Sat, 28 Apr 2007 18:00:06 +0000 Sadrul Habib Chowdhury Whitespace fix from patch in ticket #383
Sat, 28 Apr 2007 04:22:37 +0000 Richard Laager Make this yahoo hack compile.
Sat, 28 Apr 2007 04:00:54 +0000 Richard Laager In theory, this solves the massive pile of g_log errors that occur when
Sun, 29 Apr 2007 01:08:11 +0000 Richard Laager Fix a bug with the bugfix for empty icons. The logic was backwards here.
Sat, 28 Apr 2007 02:29:48 +0000 Richard Laager merge of '45acf7a629de79f67b489f696c7915cd9984f33e'
Sat, 28 Apr 2007 02:29:26 +0000 Richard Laager Minor whitespace tweak.
Sat, 28 Apr 2007 02:24:40 +0000 Richard Laager nosnilmot had a problem with empty icon files.
Sat, 28 Apr 2007 02:29:43 +0000 Richard Laager disapproval of revision 'cf51292b9bf12554eecb319a673f153ef5c6f0e4'
Fri, 27 Apr 2007 20:21:41 +0000 Daniel Atallah Prevent sprintf(%s, NULL) when the icon type isn't recognized.
Fri, 27 Apr 2007 04:35:59 +0000 Richard Laager I really shouldn't commit before compiling.
Fri, 27 Apr 2007 04:33:26 +0000 Richard Laager This is probably needed to compile.
Fri, 27 Apr 2007 04:29:05 +0000 Richard Laager Fix a small-but-serious bug with the code to ref the buddy icons at load.
Fri, 27 Apr 2007 04:28:41 +0000 Richard Laager Ref the filenames for account buddy icons on load.
Wed, 25 Apr 2007 23:29:46 +0000 Richard Laager Kill some compiler warnings and TODOs of mine.
Wed, 25 Apr 2007 22:23:29 +0000 Richard Laager Change the imgstore and by extension, then the buddy icon code to take over
Wed, 25 Apr 2007 21:48:56 +0000 Richard Laager Updates for the account buddy icon stuff. This doesn't yet work fully (and maybe not even partly), but it compiles.
Wed, 25 Apr 2007 01:19:24 +0000 Richard Laager I'm stupid. If an icon doesn't exist, it's a good idea to create it when we want to fill it with data, not when we don't.
less more | (0) -60 tip