| Fri, 04 Apr 2008 04:42:26 +0000 |
Mark Doliner |
Documentation changes
|
| Thu, 03 Apr 2008 23:51:19 +0000 |
Mark Doliner |
Better documentation.
|
| Tue, 04 Mar 2008 23:53:44 +0000 |
Evan Schoenberg |
Just write out the buddy icon file; there's no need to check to see if it exists. This is for the cache, and if the blist.xml gets out of sync with the cache on disk (for example, because the user moves the blist.xml file out of the way), the existing code will never update the cached icon again.
|
| Tue, 04 Mar 2008 00:11:22 +0000 |
Evan Schoenberg |
When purple_buddy_icons_set_account_icon() is called, it unrefs the old PurpleStoredImage and refs the new one. Previously, it notified the prpl of the change in the buddy icon before updating pointer_icon_cache, which meant that if the prpl then called purple_buddy_icons_find_account_icon() it would get the old PurpleStoredImage (which is at this point not only old but also a pointer to invalid memory if unref'ing it caused it to be destroyed). This happens in jabber_set_info() as of 2.4.0, causing a crash when setting no-buddy-icon for an account after it has previously had an icon. I think this also means that XMPP accounts in 2.4.0 will also always set serverside the *last* icon set, not the current one, when changing icons, but I didn't test that.
|
| Sun, 03 Feb 2008 19:43:41 +0000 |
John Bailey |
Kill off gc->prpl in the core everywhere but connection.c (when the struct
|
| Wed, 23 Jan 2008 05:16:39 +0000 |
Sadrul Habib Chowdhury |
We need to store the img in the hashtable only after we have removed the old
|
| Tue, 08 Jan 2008 22:01:22 +0000 |
Evan Schoenberg |
merge of '5d18b4aee9c05f592af532f9155aadb23ad11d4b'
|
| Tue, 08 Jan 2008 03:02:08 +0000 |
Stu Tomlinson |
Apparently "nil" is an Objective-C thing
|
| Tue, 08 Jan 2008 21:58:31 +0000 |
Evan Schoenberg |
If the UI sets a cache directory before purple_buddy_icons_init() is called
|
| Tue, 08 Jan 2008 02:47:51 +0000 |
Evan Schoenberg |
There's nothing wrong with calling purple_buddy_icons_find() can not receiving an icon in return - it just means that no icon was found. We shouldn't attempt to call purple_buddy_icon_ref() on NULL, which will trigger a failed assertion.
|
| Mon, 07 Jan 2008 23:20:40 +0000 |
Evan Schoenberg |
Remove spurious braces
|
| Mon, 07 Jan 2008 09:14:39 +0000 |
Sadrul Habib Chowdhury |
compile
|
| Mon, 07 Jan 2008 00:32:26 +0000 |
Evan Schoenberg |
If the cached buddy icon can't be loaded, delete the preferences which point to it. Among other things, this fixes OSCAR buddy icon retrieval when the cache has been removed - since previously the icon hash was kept around and was used to determine that (so far as the prpl could tell) no icon retrieval was needed, libpurple would never have an icon for the contact.
|
| Fri, 04 Jan 2008 21:30:24 +0000 |
Daniel Atallah |
We can't rely on g_strerror() being set by g_file_test().
|
| Mon, 17 Dec 2007 07:29:39 +0000 |
Sean Egan |
Patch from eperez to make writing to buddy icon files atomic. Fixes #3528.
|
