log libpurple/buddyicon.c @ 22546:d93577159f2a

age author description
2008-03-04 Evan Schoenberg Just write out the buddy icon file; there's no need to check to see if it exists. This is for the cache, and if the blist.xml gets out of sync with the cache on disk (for example, because the user moves the blist.xml file out of the way), the existing code will never update the cached icon again.
2008-03-04 Evan Schoenberg When purple_buddy_icons_set_account_icon() is called, it unrefs the old PurpleStoredImage and refs the new one. Previously, it notified the prpl of the change in the buddy icon before updating pointer_icon_cache, which meant that if the prpl then called purple_buddy_icons_find_account_icon() it would get the old PurpleStoredImage (which is at this point not only old but also a pointer to invalid memory if unref'ing it caused it to be destroyed). This happens in jabber_set_info() as of 2.4.0, causing a crash when setting no-buddy-icon for an account after it has previously had an icon. I think this also means that XMPP accounts in 2.4.0 will also always set serverside the *last* icon set, not the current one, when changing icons, but I didn't test that.
2008-02-03 John Bailey Kill off gc->prpl in the core everywhere but connection.c (when the struct
2008-01-23 Sadrul Habib Chowdhury We need to store the img in the hashtable only after we have removed the old
2008-01-08 Evan Schoenberg merge of '5d18b4aee9c05f592af532f9155aadb23ad11d4b'
2008-01-08 Stu Tomlinson Apparently "nil" is an Objective-C thing
2008-01-08 Evan Schoenberg If the UI sets a cache directory before purple_buddy_icons_init() is called
2008-01-08 Evan Schoenberg There's nothing wrong with calling purple_buddy_icons_find() can not receiving an icon in return - it just means that no icon was found. We shouldn't attempt to call purple_buddy_icon_ref() on NULL, which will trigger a failed assertion.
2008-01-07 Evan Schoenberg Remove spurious braces
2008-01-07 Sadrul Habib Chowdhury compile
2008-01-07 Evan Schoenberg If the cached buddy icon can't be loaded, delete the preferences which point to it. Among other things, this fixes OSCAR buddy icon retrieval when the cache has been removed - since previously the icon hash was kept around and was used to determine that (so far as the prpl could tell) no icon retrieval was needed, libpurple would never have an icon for the contact.
2008-01-04 Daniel Atallah We can't rely on g_strerror() being set by g_file_test().
2007-12-17 Sean Egan Patch from eperez to make writing to buddy icon files atomic. Fixes #3528.
2007-11-19 Ka-Hing Cheung prpl->set_buddy_icon may keep a reference to PurpleStoredImage, move the
2007-11-03 Nathan Walp replace most calls to strerror with calls to g_strerror. strerror will return
2007-10-21 Luke Schierer applied changes from 3ae1e4b3dac8092886b4b8ab961d8d505433b4c4
2007-09-16 Sean Egan remove gpl boilerplate from doxygen docs
2007-09-08 John Bailey The FSF changed its address a while ago; our files were out of date.
2007-06-16 Richard Laager disapproval of revision '1411afd7660760db59966c3a9f18e2adab8eb27e'
2007-06-07 Richard Laager Mark the return type const for the following functions. I noticed this
2007-06-04 Richard Laager A patch from David Grohmann (dave1g) to log embedded images.
2007-05-09 Richard Laager Patch from ticket #819 from vampire
2007-05-04 Richard Laager Fix a reference counting bug.
2007-05-03 Richard Laager merge of 'df3320af10ba54cf6129f203dedb82f35baf6800'
2007-05-03 Evan Schoenberg Protect icon with ref/unref guards since it may be freed over the course of the while() loop. I thought this would fix #398, but something else is wrong, too.
2007-05-03 Sadrul Habib Chowdhury Remove two warnings, one compile-time, one runtime. Plug two leaks, both runtime.
2007-05-03 Richard Laager Rework purple_buddy_icons_find() to return a reference for the caller, which
2007-05-03 Mark Doliner Change a few functions to free a linked list while iterating through
2007-04-30 Mark Doliner Get rid of two harmless warnings:
2007-04-29 Richard Laager Document the image-deleting signal.
2007-04-29 Sadrul Habib Chowdhury This gets rid of a g_log error when uncache-ing a NULL file.
2007-04-29 Richard Laager The GNOME coding guidelines recommend prefixing internal symbols with an underscore.
2007-04-29 Richard Laager merge of '2c12ac5fe6f8c8bf07d7bdde347e65c66e4f2de5'
2007-04-29 Richard Laager Add more error checking to the buddy icon migration code.
2007-04-29 Richard Laager Fix a crash when removing a per-account icon. Here's my explanation:
2007-04-29 Daniel Atallah merge of '2d00dcb7fc18b083ac949b5febda711ecfd52cdb'
2007-04-29 Richard Laager merge of '833c9b8a7ffaa6f0c0f194a0c73d46d0ec0a64e2'
2007-04-29 Richard Laager The OSCAR timestamp stuff.
2007-04-29 Daniel Atallah merge of '8bc9a8784cf40932a34e08e80f0d6585812b985a'
2007-04-29 Daniel Atallah Fix assertion when creating a new account.
2007-04-29 Richard Laager 19:00:43 Ka-Hing Cheung (khc): rlaager: shouldn't we give g_free as the key free function for icon_data_cache?
2007-04-28 Sadrul Habib Chowdhury Whitespace fix from patch in ticket #383
2007-04-28 Richard Laager Make this yahoo hack compile.
2007-04-28 Richard Laager In theory, this solves the massive pile of g_log errors that occur when
2007-04-29 Richard Laager Fix a bug with the bugfix for empty icons. The logic was backwards here.
2007-04-28 Richard Laager merge of '45acf7a629de79f67b489f696c7915cd9984f33e'
2007-04-28 Richard Laager Minor whitespace tweak.
2007-04-28 Richard Laager nosnilmot had a problem with empty icon files.
2007-04-28 Richard Laager disapproval of revision 'cf51292b9bf12554eecb319a673f153ef5c6f0e4'
2007-04-27 Daniel Atallah Prevent sprintf(%s, NULL) when the icon type isn't recognized.
2007-04-27 Richard Laager I really shouldn't commit before compiling.
2007-04-27 Richard Laager This is probably needed to compile.
2007-04-27 Richard Laager Fix a small-but-serious bug with the code to ref the buddy icons at load.
2007-04-27 Richard Laager Ref the filenames for account buddy icons on load.
2007-04-25 Richard Laager Kill some compiler warnings and TODOs of mine.
2007-04-25 Richard Laager Change the imgstore and by extension, then the buddy icon code to take over
2007-04-25 Richard Laager Updates for the account buddy icon stuff. This doesn't yet work fully (and maybe not even partly), but it compiles.
2007-04-25 Richard Laager I'm stupid. If an icon doesn't exist, it's a good idea to create it when we want to fill it with data, not when we don't.
2007-04-25 Richard Laager Move the prpl icon checksum code into the core, so we can delete the
2007-04-24 Richard Laager Fix a bug with removing custom buddy icons.