# HG changeset patch # User Mark Doliner # Date 1302653811 0 # Node ID 1527020e33e2c4bf526229558ddb9944979094ec # Parent d4b7770324f8074edc4bd2d8b91655191e1195b0 In purple_buddy_icons_set_account_icon, call the prpl's set_buddy_icon function if the account is in the connecting state (not just connected). I believe this is the polite thing to do. I'm seeing a little race condition in the jabber prpl where if the user changes their icon while the account is connecting, the new icon isn't set. This is one half of the fix. I don't _think_ this will cause problems. It's possible that some prpls will be unhappy if a user tries to set an icon while the account is connecting. If those problems exist, I think they should be fixed in each prpl. diff -r d4b7770324f8 -r 1527020e33e2 libpurple/buddyicon.c --- a/libpurple/buddyicon.c Sat Apr 02 18:04:29 2011 +0000 +++ b/libpurple/buddyicon.c Wed Apr 13 00:16:51 2011 +0000 @@ -756,7 +756,7 @@ else g_hash_table_remove(pointer_icon_cache, account); - if (purple_account_is_connected(account)) + if (!purple_account_is_disconnected(account)) { PurpleConnection *gc; PurplePluginProtocolInfo *prpl_info;