# HG changeset patch # User Mark Doliner # Date 1202636737 0 # Node ID 2222a596340f97379b1ad069bf4afa2aff248392 # Parent f8dde302fcb2ae97276858d21f0d46576a113ad1 A patch from oliver to speed up oscar's normalize function a little by removing a call to strncpy(). Fixes #4816. diff -r f8dde302fcb2 -r 2222a596340f libpurple/protocols/oscar/oscar.c --- a/libpurple/protocols/oscar/oscar.c Sat Feb 09 09:04:39 2008 +0000 +++ b/libpurple/protocols/oscar/oscar.c Sun Feb 10 09:45:37 2008 +0000 @@ -6609,18 +6609,18 @@ g_return_val_if_fail(str != NULL, NULL); - strncpy(buf, str, BUF_LEN); - for (i=0, j=0; buf[j]; i++, j++) + /* copy str to buf and skip all blanks */ + for (i=0, j=0; str[j] && i < BUF_LEN; i++, j++) { - while (buf[j] == ' ') + while (str[j] == ' ') j++; - buf[i] = buf[j]; + buf[i] = str[j]; } buf[i] = '\0'; tmp1 = g_utf8_strdown(buf, -1); tmp2 = g_utf8_normalize(tmp1, -1, G_NORMALIZE_DEFAULT); - g_snprintf(buf, sizeof(buf), "%s", tmp2); + strcpy(buf, tmp2); g_free(tmp2); g_free(tmp1);