# HG changeset patch # User Richard Laager # Date 1141697736 0 # Node ID 2ec69a9763a5f86595c1604bebb52ac3b704ea26 # Parent d6530e0cd89fb4a7fa00bbfe2597b839acf55845 [gaim-migrate @ 15796] Resolve CID 16: Event var_compare_op: Added "gc" due to comparison "gc != 0" 126 if (gc != NULL && gc->prpl != NULL) 127 prpl_info = GAIM_PLUGIN_PROTOCOL_INFO(gc->prpl); Event var_deref_op: Variable "gc" tracked as NULL was dereferenced. 132 conv = gaim_find_conversation_with_account(GAIM_CONV_TYPE_IM, name, gc->account); I've changed the gc and gc->prpl NULL checks into a g_return_if_fail(). committer: Tailor Script diff -r d6530e0cd89f -r 2ec69a9763a5 src/server.c --- a/src/server.c Tue Mar 07 02:11:59 2006 +0000 +++ b/src/server.c Tue Mar 07 02:15:36 2006 +0000 @@ -119,12 +119,14 @@ GaimConversation *conv; GaimAccount *account; GaimPresence *presence; - GaimPluginProtocolInfo *prpl_info = NULL; + GaimPluginProtocolInfo *prpl_info; int val = -EINVAL; const gchar *auto_reply_pref; - if (gc != NULL && gc->prpl != NULL) - prpl_info = GAIM_PLUGIN_PROTOCOL_INFO(gc->prpl); + g_return_val_if_fail(gc != NULL, val); + g_return_val_if_fail(gc->prpl != NULL, val); + + prpl_info = GAIM_PLUGIN_PROTOCOL_INFO(gc->prpl); account = gaim_connection_get_account(gc); presence = gaim_account_get_presence(account);