# HG changeset patch
# User Mark Doliner <mark@kingant.net>
# Date 1128922944 0
# Node ID 2f7558b0c01b215356e72d75642d1c6bc8580527
# Parent  e95c37720766621bc8e175f7a4531554b9b3498d
[gaim-migrate @ 13912]
Don't freaking rebuild the tooltip twice for every mouse-over popup
in the buddy list.

committer: Tailor Script <tailor@pidgin.im>

diff -r e95c37720766 -r 2f7558b0c01b src/gtkblist.c
--- a/src/gtkblist.c	Mon Oct 10 05:12:55 2005 +0000
+++ b/src/gtkblist.c	Mon Oct 10 05:42:24 2005 +0000
@@ -2274,17 +2274,16 @@
 	GtkStyle *style;
 	GdkPixbuf *pixbuf = gaim_gtk_blist_get_status_icon(node, GAIM_STATUS_ICON_LARGE);
 	PangoLayout *layout;
-	char *tooltiptext = gaim_get_tooltip_text(node);
 	GdkPixbuf *avatar = NULL;
 	int layout_width, layout_height;
 
-	if(!tooltiptext)
+	if(gtkblist->tooltiptext == NULL)
 		return;
 
 	avatar = gaim_gtk_blist_get_buddy_icon(node, FALSE, FALSE);
 
 	layout = gtk_widget_create_pango_layout (gtkblist->tipwindow, NULL);
-	pango_layout_set_markup(layout, tooltiptext, strlen(tooltiptext));
+	pango_layout_set_markup(layout, gtkblist->tooltiptext, strlen(gtkblist->tooltiptext));
 	pango_layout_set_wrap(layout, PANGO_WRAP_WORD);
 	pango_layout_set_width(layout, 300000);
 	{
@@ -2320,7 +2319,6 @@
 
 	g_object_unref (pixbuf);
 	g_object_unref (layout);
-	g_free(tooltiptext);
 
 #ifdef WANT_DROP_SHADOW
 	if (!xcomposite_is_present()) {
@@ -2334,11 +2332,15 @@
 
 static void gaim_gtk_blist_tooltip_destroy()
 {
+	g_free(gtkblist->tooltiptext);
+	gtkblist->tooltiptext = NULL;
+
 	if (gtkblist->tipwindow == NULL)
 		return;
 
 	gtk_widget_destroy(gtkblist->tipwindow);
 	gtkblist->tipwindow = NULL;
+
 #ifdef WANT_DROP_SHADOW
 	if (!xcomposite_is_present()) {
 		gdk_window_set_user_data (gtkblist->east_shadow, NULL);
@@ -2352,7 +2354,6 @@
 #endif
 }
 
-
 static gboolean gaim_gtk_blist_expand_timeout(GtkWidget *tv)
 {
 	GtkTreePath *path;
@@ -2407,13 +2408,18 @@
 #endif
 	PangoLayout *layout;
 	gboolean tooltip_top = FALSE;
-	char *tooltiptext = NULL;
 	struct _gaim_gtk_blist_node *gtknode;
 	GdkRectangle mon_size;
 #ifdef WANT_DROP_SHADOW
 	GdkWindowAttr attr;
 #endif
 
+	/*
+	 * Attempt to free the previous tooltip.  I have a feeling
+	 * this is never needed... but just in case.
+	 */
+	gaim_gtk_blist_tooltip_destroy();
+
 	if (!gtk_tree_view_get_path_at_pos(GTK_TREE_VIEW(tv), gtkblist->tip_rect.x, gtkblist->tip_rect.y, &path, NULL, NULL, NULL))
 		return FALSE;
 	gtk_tree_model_get_iter(GTK_TREE_MODEL(gtkblist->treemodel), &iter, path);
@@ -2428,13 +2434,10 @@
 
 	gtknode = node->ui_data;
 
-	tooltiptext = gaim_get_tooltip_text(node);
-
-	if(!tooltiptext)
+	gtkblist->tooltiptext = gaim_get_tooltip_text(node);
+	if (gtkblist->tooltiptext == NULL)
 		return FALSE;
 
-	if(gtkblist->tipwindow)
-		gtk_widget_destroy(gtkblist->tipwindow);
 	gtkblist->tipwindow = gtk_window_new(GTK_WINDOW_POPUP);
 	gtk_widget_set_app_paintable(gtkblist->tipwindow, TRUE);
 	gtk_window_set_resizable(GTK_WINDOW(gtkblist->tipwindow), FALSE);
@@ -2459,19 +2462,11 @@
 
 		attr.event_mask |= (GDK_EXPOSURE_MASK | GDK_KEY_PRESS_MASK |
 				    GDK_ENTER_NOTIFY_MASK | GDK_LEAVE_NOTIFY_MASK );
-		if(gtkblist->east_shadow) {
-			gdk_window_set_user_data (gtkblist->east_shadow, NULL);
-			gdk_window_destroy (gtkblist->east_shadow);
-		}
 		gtkblist->east_shadow = gdk_window_new(gtk_widget_get_root_window(gtkblist->tipwindow), &attr,
 										   GDK_WA_NOREDIR | GDK_WA_VISUAL | GDK_WA_COLORMAP);
 		gdk_window_set_user_data (gtkblist->east_shadow, gtkblist->tipwindow);
 		gdk_window_set_back_pixmap (gtkblist->east_shadow, NULL, FALSE);
 
-		if(gtkblist->south_shadow) {
-			gdk_window_set_user_data (gtkblist->south_shadow, NULL);
-			gdk_window_destroy (gtkblist->south_shadow);
-		}
 		gtkblist->south_shadow = gdk_window_new(gtk_widget_get_root_window(gtkblist->tipwindow), &attr,
 											GDK_WA_NOREDIR | GDK_WA_VISUAL | GDK_WA_COLORMAP);
 		gdk_window_set_user_data (gtkblist->south_shadow, gtkblist->tipwindow);
@@ -2482,7 +2477,7 @@
 	layout = gtk_widget_create_pango_layout (gtkblist->tipwindow, NULL);
 	pango_layout_set_wrap(layout, PANGO_WRAP_WORD);
 	pango_layout_set_width(layout, 300000);
-	pango_layout_set_markup(layout, tooltiptext, strlen(tooltiptext));
+	pango_layout_set_markup(layout, gtkblist->tooltiptext, strlen(gtkblist->tooltiptext));
 	pango_layout_get_size (layout, &w, &h);
 
 #if GTK_CHECK_VERSION(2,2,0)
@@ -2552,7 +2547,6 @@
 	}
 
 	g_object_unref (layout);
-	g_free(tooltiptext);
 	gtk_widget_set_size_request(gtkblist->tipwindow, w, h);
 	gtk_window_move(GTK_WINDOW(gtkblist->tipwindow), x, y);
 	gtk_widget_show(gtkblist->tipwindow);