# HG changeset patch # User Tim Ringenbach # Date 1177467953 0 # Node ID 34618fedf5b94e344c8c3641c3cbb0a54f64f55c # Parent a0cae757170f034313cdfef1661a0e031e3b53f6 Update the comments about yahoo buddy icons. Only send the filename and not the whole path. diff -r a0cae757170f -r 34618fedf5b9 libpurple/protocols/yahoo/yahoo_picture.c --- a/libpurple/protocols/yahoo/yahoo_picture.c Wed Apr 25 01:12:47 2007 +0000 +++ b/libpurple/protocols/yahoo/yahoo_picture.c Wed Apr 25 02:25:53 2007 +0000 @@ -546,7 +546,9 @@ /* TODO: At some point, it'd be nice to fix this for real, or * TODO: at least change it to be something like: - * TODO: purple_imgstore_get_filename(img); */ + * TODO: purple_imgstore_get_filename(img); + * TODO: But it would be great if we knew how to calculate the + * TODO: Checksum correctly. */ yd->picture_checksum = g_string_hash(s); if ((yd->picture_checksum == oldcksum) && @@ -559,10 +561,8 @@ return; } - /* TODO: FIXME: This is completely wrong. The upload code needs to - * TODO: be modified to work with a PurpleStoredImage. */ - iconfile = g_build_filename(purple_buddy_icons_get_cache_dir(), - purple_imgstore_get_filename(img), NULL); + /* We use this solely for sending a filename to the server */ + iconfile = g_strdup(purple_imgstore_get_filename(img)); d = g_new0(struct yahoo_buddy_icon_upload_data, 1); d->gc = gc; d->str = s;