# HG changeset patch
# User Paul Aurich <paul@darkrain42.org>
# Date 1247893705 0
# Node ID 37b668b8d6c102e90b3f96e296e3cf5d1d80c14f
# Parent  4e1eef14b0955f0add5c0a7d2f4ac7d1a2799352
Fix a crash with the Message Notification plugin and the 'hidden' gtkconv

So I was finally able to reproduce this. "Close IMs immediately" was
disabled and in the Message Notification plugin's settings, everything
is disabled except "[Notify for ]IM windows" and
"Present conversation window".

In my testing, this did not prevent the conversation from re-attaching
when a new message comes on. Fixes #8911.

diff -r 4e1eef14b095 -r 37b668b8d6c1 ChangeLog
--- a/ChangeLog	Sat Jul 18 04:06:48 2009 +0000
+++ b/ChangeLog	Sat Jul 18 05:08:25 2009 +0000
@@ -156,6 +156,8 @@
 	  (Kosta Arvanitis)
 	* When file transfers are complete, the received file name written to the
 	  conversation window is now linked to the file.
+	* Fix a crash when closing a conversation tab that has unread messages
+	  when the Message Notification plugin is loaded.
 
 	Finch:
 	* The hardware cursor is updated correctly. This will be useful
diff -r 4e1eef14b095 -r 37b668b8d6c1 pidgin/plugins/notify.c
--- a/pidgin/plugins/notify.c	Sat Jul 18 04:06:48 2009 +0000
+++ b/pidgin/plugins/notify.c	Sat Jul 18 05:08:25 2009 +0000
@@ -572,6 +572,9 @@
 static void
 handle_present(PurpleConversation *conv)
 {
+	if (pidgin_conv_is_hidden(PIDGIN_CONVERSATION(conv)))
+		return;
+
 	purple_conversation_present(conv);
 }