# HG changeset patch # User Daniel Atallah # Date 1192554591 0 # Node ID 3e10bdc691d2c414d189f98cb4bf0984bcee5019 # Parent 6b9c49ae774cf0647dc6e253b45809db86643704 Prevent a crash when the proxy username isn't specified. Fixes #3583. diff -r 6b9c49ae774c -r 3e10bdc691d2 libpurple/proxy.c --- a/libpurple/proxy.c Tue Oct 16 08:01:45 2007 +0000 +++ b/libpurple/proxy.c Tue Oct 16 17:09:51 2007 +0000 @@ -690,11 +690,12 @@ gchar *tmp = ntlm; guint8 *nonce; gchar *domain = (gchar*)purple_proxy_info_get_username(connect_data->gpi); - gchar *username; + gchar *username = NULL; gchar *request; gchar *response; - username = strchr(domain, '\\'); + if (domain != NULL) + username = strchr(domain, '\\'); if (username == NULL) { purple_proxy_connect_data_disconnect_formatted(connect_data, @@ -738,9 +739,11 @@ } else if((ntlm = g_strrstr((const char *)connect_data->read_buffer, "Proxy-Authenticate: NTLM"))) { /* Empty message */ gchar request[2048]; gchar *domain = (gchar*) purple_proxy_info_get_username(connect_data->gpi); - gchar *username; + gchar *username = NULL; int request_len; - username = strchr(domain, '\\'); + + if (domain != NULL) + username = strchr(domain, '\\'); if (username == NULL) { purple_proxy_connect_data_disconnect_formatted(connect_data,