# HG changeset patch # User Paul Aurich # Date 1311218778 0 # Node ID 3ef5e744589c8542c000ab23b8784e81424084b0 # Parent 6da9e43e17d82992f2b9d4935ad554b2f6a141cc sametime: Avoid a theoretical null strcmp We don't ever call group_ensure() with a non-null group, and libmeanwhile takes steps to ensure a group never has a NULL name, so this can't happen. But this makes clang happier. diff -r 6da9e43e17d8 -r 3ef5e744589c libpurple/protocols/sametime/sametime.c --- a/libpurple/protocols/sametime/sametime.c Thu Jul 21 03:16:51 2011 +0000 +++ b/libpurple/protocols/sametime/sametime.c Thu Jul 21 03:26:18 2011 +0000 @@ -922,6 +922,11 @@ alias = mwSametimeGroup_getAlias(stgroup); type = mwSametimeGroup_getType(stgroup); + if (!name) { + DEBUG_WARN("Can't ensure a null group\n"); + return + } + DEBUG_INFO("attempting to ensure group %s, called %s\n", NSTR(name), NSTR(alias));