# HG changeset patch # User Paul Aurich # Date 1240727215 0 # Node ID 46b1d6eca6eff9bf461810291e2afb142d884e83 # Parent 81559f83e99399fe39b4c21caa8b9bc28b0d7a6f Avoid dereferencing unitialized memory or leaking PidginThemeFonts diff -r 81559f83e993 -r 46b1d6eca6ef pidgin/gtkblist-theme-loader.c --- a/pidgin/gtkblist-theme-loader.c Sun Apr 26 06:22:50 2009 +0000 +++ b/pidgin/gtkblist-theme-loader.c Sun Apr 26 06:26:55 2009 +0000 @@ -81,6 +81,17 @@ {NULL, NULL} }; + expanded = NULL; + collapsed = NULL; + contact = NULL; + online = NULL; + away = NULL; + offline = NULL; + idle = NULL; + message = NULL; + message_nick_said = NULL; + status = NULL; + /* Find the theme file */ g_return_val_if_fail(dir != NULL, NULL); filename_full = g_build_filename(dir, "theme.xml", NULL); @@ -184,6 +195,10 @@ pidgin_theme_font_free(*lookups[i].font); } } + + pidgin_theme_font_free(expanded); + pidgin_theme_font_free(collapsed); + xmlnode_free(root_node); g_free(data);