# HG changeset patch
# User Etan Reisner <pidgin@unreliablesource.net>
# Date 1137913746 0
# Node ID 4e9935a539dba6f41dedfba32e226a1b7722061e
# Parent  de3a3669dbe19feabd2c9d16eafbad0e4d4065a8
[gaim-migrate @ 15339]
We need to figure this out so that things don't break again. The new plugin
dependency unload code assumed that all plugins would have ids set, this was
true for most plugins, but both the perl and tcl loaders didn't set id for
perl and tcl plugins. And I didn't see any code in my quick looking which
actually verified (m)any parts of the struct.

committer: Tailor Script <tailor@pidgin.im>

diff -r de3a3669dbe1 -r 4e9935a539db src/plugin.h
--- a/src/plugin.h	Sun Jan 22 07:06:30 2006 +0000
+++ b/src/plugin.h	Sun Jan 22 07:09:06 2006 +0000
@@ -66,6 +66,11 @@
  *
  * This is used in the version 2.0 API and up.
  */
+/* TODO We need to figure out exactly what parts of this are required. The
+ * dependent plugin unloading stuff was causing crashes with perl and tcl
+ * plugins because they didn't set ids and the dependency code was requiring
+ * them. Then we need to actually make sure that plugins have all the right
+ * parts before loading them. */
 struct _GaimPluginInfo
 {
 	unsigned int magic;