# HG changeset patch # User Paul Aurich # Date 1284953112 0 # Node ID 53dcfcc71953a1f0e6413b45e68e1b9332bfc243 # Parent 3f5ff1ea48020081f31b2f86ece64ec7c9247529 jabber: Comment the problematic behavior of jabber_add_(feature|identity) diff -r 3f5ff1ea4802 -r 53dcfcc71953 libpurple/protocols/jabber/jabber.h --- a/libpurple/protocols/jabber/jabber.h Mon Sep 20 00:51:21 2010 +0000 +++ b/libpurple/protocols/jabber/jabber.h Mon Sep 20 03:25:12 2010 +0000 @@ -338,11 +338,25 @@ */ char *jabber_parse_error(JabberStream *js, xmlnode *packet, PurpleConnectionError *reason); -void jabber_add_feature(const gchar *namespace, JabberFeatureEnabled cb); /* cb may be NULL */ +/** + * Add a feature to the list of features advertised via disco#info. If you + * call this while accounts are connected, Bad Things(TM) will happen because + * the Entity Caps hash will be out-of-date (which should be fixed :/) + * + * @param namespace The namespace of the feature + * @param cb A callback determining whether or not this feature + * will advertised; may be NULL. + */ +void jabber_add_feature(const gchar *namespace, JabberFeatureEnabled cb); void jabber_remove_feature(const gchar *namespace); -/** Adds an identity to this jabber library instance. For list of valid values visit the - * website of the XMPP Registrar ( http://www.xmpp.org/registrar/disco-categories.html#client ). +/** Adds an identity to this jabber library instance. For list of valid values + * visit the website of the XMPP Registrar + * (http://www.xmpp.org/registrar/disco-categories.html#client). + * + * Like with jabber_add_feature, if you call this while accounts are connected, + * Bad Things will happen. + * * @param category the category of the identity. * @param type the type of the identity. * @param language the language localization of the name. Can be NULL.