# HG changeset patch # User Casey Harkins # Date 1192421596 0 # Node ID 5c849ee68659e1bd03fd8114b8bde5e0da3ddc31 # Parent 2cf9156f4b8567e44e0084969563620c0ab12d1a Make the docklet blink again for unread messages. Fixes #3211. diff -r 2cf9156f4b85 -r 5c849ee68659 pidgin/gtkconv.c --- a/pidgin/gtkconv.c Mon Oct 15 04:07:28 2007 +0000 +++ b/pidgin/gtkconv.c Mon Oct 15 04:13:16 2007 +0000 @@ -2853,9 +2853,6 @@ if (gtkconv != NULL && gtkconv->active_conv != conv) continue; if (gtkconv == NULL) { - if (!hidden_only || - !purple_conversation_get_data(conv, "unseen-count")) - continue; r = g_list_prepend(r, conv); c++; } else { diff -r 2cf9156f4b85 -r 5c849ee68659 pidgin/gtkdocklet.c --- a/pidgin/gtkdocklet.c Mon Oct 15 04:07:28 2007 +0000 +++ b/pidgin/gtkdocklet.c Mon Oct 15 04:13:16 2007 +0000 @@ -145,15 +145,22 @@ if (ui_ops->set_tooltip) { GString *tooltip_text = g_string_new(""); for (l = convs, count = 0 ; l != NULL ; l = l->next, count++) { - if (PIDGIN_IS_PIDGIN_CONVERSATION(l->data)) { - PidginConversation *gtkconv = PIDGIN_CONVERSATION((PurpleConversation *)l->data); - if (count == DOCKLET_TOOLTIP_LINE_LIMIT - 1) - g_string_append(tooltip_text, _("Right-click for more unread messages...\n")); - else - g_string_append_printf(tooltip_text, - ngettext("%d unread message from %s\n", "%d unread messages from %s\n", gtkconv->unseen_count), - gtkconv->unseen_count, - gtk_label_get_text(GTK_LABEL(gtkconv->tab_label))); + PurpleConversation *conv = (PurpleConversation *)l->data; + PidginConversation *gtkconv = PIDGIN_CONVERSATION(conv); + + if (count == DOCKLET_TOOLTIP_LINE_LIMIT - 1) { + g_string_append(tooltip_text, _("Right-click for more unread messages...\n")); + } else if(gtkconv) { + g_string_append_printf(tooltip_text, + ngettext("%d unread message from %s\n", "%d unread messages from %s\n", gtkconv->unseen_count), + gtkconv->unseen_count, + gtk_label_get_text(GTK_LABEL(gtkconv->tab_label))); + } else { + g_string_append_printf(tooltip_text, + ngettext("%d unread message from %s\n", "%d unread messages from %s\n", + GPOINTER_TO_INT(purple_conversation_get_data(conv, "unseen-count"))), + GPOINTER_TO_INT(purple_conversation_get_data(conv, "unseen-count")), + purple_conversation_get_name(conv)); } } @@ -758,7 +765,7 @@ if (pending) { GList *l = get_pending_list(1); if (l != NULL) { - purple_conversation_present((PurpleConversation *)l->data); + pidgin_conv_present_conversation((PurpleConversation *)l->data); g_list_free(l); } } else {