# HG changeset patch
# User Marcus Lundblad <ml@update.uu.se>
# Date 1229463966 0
# Node ID 69cf692c09f58a4695b123f78afa05f572b50244
# Parent  b535b9ffb9294a8b16ca494f6d6ffad64785e53d
Fix error handling on missing "seq" attribute

diff -r b535b9ffb929 -r 69cf692c09f5 libpurple/protocols/jabber/ibb.c
--- a/libpurple/protocols/jabber/ibb.c	Tue Dec 16 19:18:41 2008 +0000
+++ b/libpurple/protocols/jabber/ibb.c	Tue Dec 16 21:46:06 2008 +0000
@@ -395,12 +395,11 @@
 				"Got IBB iq from wrong JID, ignoring\n");
 		} else if (data) {
 			const gchar *seq_attr = xmlnode_get_attrib(data, "seq");
-			guint16 seq = 0;
+			guint16 seq = (seq_attr ? atoi(seq_attr) : 0);
 
 			/* reject the data, and set the session in error if we get an
 			  out-of-order packet */
-			if (seq_attr && (seq = atoi(seq_attr)) &&
-					seq == jabber_ibb_session_get_recv_seq(sess)) {
+			if (seq_attr && seq == jabber_ibb_session_get_recv_seq(sess)) {
 				/* sequence # is the expected... */
 				JabberIq *result = jabber_iq_new(js, JABBER_IQ_RESULT);