# HG changeset patch # User Paul Aurich # Date 1311226788 0 # Node ID 6d6056e176fecd7f7a0bb8caa01f10b8abeed421 # Parent d6c47cc28870f9502a4ac71d5afc35569984e096 log_reader: Fix an actual crash in the QIP reader. This crashes if there's at least two lines, and the last line doesn't contain a trailing newline. E.g: "\n<-- foo -->" written to a file. diff -r d6c47cc28870 -r 6d6056e176fe ChangeLog --- a/ChangeLog Thu Jul 21 05:37:06 2011 +0000 +++ b/ChangeLog Thu Jul 21 05:39:48 2011 +0000 @@ -9,6 +9,9 @@ * Fix building with GTK+ earlier than 2.14.0 (GTK+ 2.10 is still the minimum supported) (#14261) + libpurple: + * Fix a potential crash in the Log Reader plugin when reading QIP logs. + Gadu-Gadu: * Fixed searching for buddies in public directory. (Tomasz Wasilczyk) (#5242) diff -r d6c47cc28870 -r 6d6056e176fe libpurple/plugins/log_reader.c --- a/libpurple/plugins/log_reader.c Thu Jul 21 05:37:06 2011 +0000 +++ b/libpurple/plugins/log_reader.c Thu Jul 21 05:39:48 2011 +0000 @@ -1901,7 +1901,7 @@ start_log = new_line; } - if (*c) { + if (c && *c) { /* find EOF */ c = strchr(c, '\n'); c++;