# HG changeset patch # User Mark Doliner # Date 1226481029 0 # Node ID 6e4979001d6d6904b07086cc6d4150b52d2cd936 # Parent 5b5c21b606900c4c64be8c7c97fb35a47692b26e The "processing" flag basically says "this connection is busy, don't destroy it yet, wait until it's done processing." I don't think there's any reason for us to set processing to TRUE just because we're connecting. I think this is a holdover from before our purple_proxy_connect() could be canceled. But now that it's cancelable, if we want to kill the connection we can cleanly cancel the connect without worrying about the callback being triggered. diff -r 5b5c21b60690 -r 6e4979001d6d libpurple/protocols/msn/servconn.c --- a/libpurple/protocols/msn/servconn.c Wed Nov 12 08:58:27 2008 +0000 +++ b/libpurple/protocols/msn/servconn.c Wed Nov 12 09:10:29 2008 +0000 @@ -239,15 +239,7 @@ servconn->connect_data = purple_proxy_connect(NULL, session->account, host, port, connect_cb, servconn); - if (servconn->connect_data != NULL) - { - servconn->processing = TRUE; - return TRUE; - } - else - { - return FALSE; - } + return (servconn->connect_data != NULL); } void