# HG changeset patch # User Elliott Sales de Andrade # Date 1261545317 0 # Node ID 811c12e6d9655b89d301f74fb635d8820393aca2 # Parent 78a63f5590f24b637f11263bbb52f30a14174e79 There's no need to call purple_xfer_get_type() repeatedly. diff -r 78a63f5590f2 -r 811c12e6d965 libpurple/ft.c --- a/libpurple/ft.c Wed Dec 23 04:30:12 2009 +0000 +++ b/libpurple/ft.c Wed Dec 23 05:15:17 2009 +0000 @@ -268,14 +268,16 @@ purple_xfer_choose_file_ok_cb(void *user_data, const char *filename) { PurpleXfer *xfer; + PurpleXferType type; struct stat st; gchar *dir; xfer = (PurpleXfer *)user_data; + type = purple_xfer_get_type(xfer); if (g_stat(filename, &st) != 0) { /* File not found. */ - if (purple_xfer_get_type(xfer) == PURPLE_XFER_RECEIVE) { + if (type == PURPLE_XFER_RECEIVE) { #ifndef _WIN32 int mode = W_OK; #else @@ -300,16 +302,14 @@ purple_xfer_request_denied(xfer); } } - else if ((purple_xfer_get_type(xfer) == PURPLE_XFER_SEND) && - (st.st_size == 0)) { + else if ((type == PURPLE_XFER_SEND) && (st.st_size == 0)) { purple_notify_error(NULL, NULL, _("Cannot send a file of 0 bytes."), NULL); purple_xfer_request_denied(xfer); } - else if ((purple_xfer_get_type(xfer) == PURPLE_XFER_SEND) && - S_ISDIR(st.st_mode)) { + else if ((type == PURPLE_XFER_SEND) && S_ISDIR(st.st_mode)) { /* * XXX - Sending a directory should be valid for some protocols. */ @@ -318,8 +318,7 @@ purple_xfer_request_denied(xfer); } - else if ((purple_xfer_get_type(xfer) == PURPLE_XFER_RECEIVE) && - S_ISDIR(st.st_mode)) { + else if ((type == PURPLE_XFER_RECEIVE) && S_ISDIR(st.st_mode)) { char *msg, *utf8; utf8 = g_filename_to_utf8(filename, -1, NULL, NULL, NULL); msg = g_strdup_printf(