# HG changeset patch # User Jeffrey Connelly # Date 1182749084 0 # Node ID 8ee3fd09a543c40edf8824fb667c7cab336acfcb # Parent 814992cefc9c9c75cb03befe494f3583a1f21e78 Remove lots of debugging statements, no longer needed. Along with 172d2f1fc811dba4cf65d127b27a799d1e121b58, this patch (I believe) fixes #193. The problem was that msim_close() was being called twice. Removed spurious calls, and no longer appears to crash. This now works: * Login with an invalid password. * `Protocol error, code 260: The password provided is incorrect.` (good) * Disable, and re-enable account. * Receive the same error message (good, no crash). * Repeat previous two steps ''ad nauseum'', with no crash. Closes #193. diff -r 814992cefc9c -r 8ee3fd09a543 libpurple/protocols/myspace/myspace.c --- a/libpurple/protocols/myspace/myspace.c Mon Jun 25 05:11:34 2007 +0000 +++ b/libpurple/protocols/myspace/myspace.c Mon Jun 25 05:24:44 2007 +0000 @@ -2171,24 +2171,16 @@ void msim_session_destroy(MsimSession *session) { - purple_debug_info("msim", ">>> going to check if valid\n"); - g_return_if_fail(MSIM_SESSION_VALID(session)); - purple_debug_info("msim", ">>> going to set magic\n"); - session->magic = -1; - purple_debug_info("msim", ">>> going to free rxbuf\n"); g_free(session->rxbuf); /* TODO: Remove. */ - purple_debug_info("msim", ">>> going to free user_lookup_cb\n"); g_hash_table_destroy(session->user_lookup_cb); - purple_debug_info("msim", ">>> going to free user_lookup_cb_data\n"); g_hash_table_destroy(session->user_lookup_cb_data); - purple_debug_info("msim", ">>> going to free session itself\n"); g_free(session); } @@ -2202,27 +2194,21 @@ { MsimSession *session; - purple_debug_info("msim", "msim_close: closing, gc=0x%x\n", gc); - if (gc == NULL) return; - purple_debug_info("msim", "msim_close: dereferencing gc->proto_data\n"); session = (MsimSession *)gc->proto_data; if (session == NULL) return; gc->proto_data = NULL; - purple_debug_info("msim", "msim_close: checking if session is valid\n"); if (!MSIM_SESSION_VALID(session)) return; - purple_debug_info("msim", "msim_close: about to remove inpa\n"); if (session->gc->inpa) purple_input_remove(session->gc->inpa); - purple_debug_info("msim", "msim_close: ready to destroy session\n"); msim_session_destroy(session); }