# HG changeset patch
# User Stu Tomlinson <stu@nosnilmot.com>
# Date 1160240518 0
# Node ID 972ff6ca923fdcfdaae3f2aa9683abd892e19700
# Parent  e6ea3ea8efe9bd8e2cdff514a8b0f347429286cb
[gaim-migrate @ 17437]
Fix Coverity CIDs 141 & 142 - the return value of
gtk_tree_selection_get_selected() should be checked to ensure something
is selected.

I also sensitized/desensitized the buttons as appropriate, which probably
renders the return checking redundant, but I'm playing safe.

committer: Tailor Script <tailor@pidgin.im>

diff -r e6ea3ea8efe9 -r 972ff6ca923f gtk/plugins/gevolution/add_buddy_dialog.c
--- a/gtk/plugins/gevolution/add_buddy_dialog.c	Fri Oct 06 18:25:18 2006 +0000
+++ b/gtk/plugins/gevolution/add_buddy_dialog.c	Sat Oct 07 17:01:58 2006 +0000
@@ -95,7 +95,8 @@
 
 	selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(dialog->treeview));
 
-	gtk_tree_selection_get_selected(selection, NULL, &iter);
+	if (!gtk_tree_selection_get_selected(selection, NULL, &iter))
+		return;
 
 	gtk_tree_model_get(GTK_TREE_MODEL(dialog->model), &iter,
 					   COLUMN_NAME, &fullname,
@@ -343,7 +344,11 @@
 static void
 selected_cb(GtkTreeSelection *sel, GevoAddBuddyDialog *dialog)
 {
-	gtk_widget_set_sensitive(dialog->select_button, TRUE);
+	GtkTreeSelection *selection;
+
+	selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(dialog->treeview));
+	gtk_widget_set_sensitive(dialog->select_button,
+							 gtk_tree_selection_get_selected(selection, NULL, NULL));
 }
 
 static void
diff -r e6ea3ea8efe9 -r 972ff6ca923f gtk/plugins/gevolution/assoc-buddy.c
--- a/gtk/plugins/gevolution/assoc-buddy.c	Fri Oct 06 18:25:18 2006 +0000
+++ b/gtk/plugins/gevolution/assoc-buddy.c	Sat Oct 07 17:01:58 2006 +0000
@@ -105,7 +105,11 @@
 static void
 selected_cb(GtkTreeSelection *sel, GevoAssociateBuddyDialog *dialog)
 {
-	gtk_widget_set_sensitive(dialog->assoc_button, TRUE);
+	GtkTreeSelection *selection;
+
+	selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(dialog->treeview));
+	gtk_widget_set_sensitive(dialog->assoc_button,
+							 gtk_tree_selection_get_selected(selection, NULL, NULL));
 }
 
 static void
@@ -276,7 +280,8 @@
 
 	selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(dialog->treeview));
 
-	gtk_tree_selection_get_selected(selection, NULL, &iter);
+	if (!gtk_tree_selection_get_selected(selection, NULL, &iter))
+		return;
 
 	gtk_tree_model_get(GTK_TREE_MODEL(dialog->model), &iter,
 					   COLUMN_NAME, &fullname,