# HG changeset patch # User Mark Doliner # Date 1226699199 0 # Node ID 9b61b1088dfba6e8cd939a626cec69fde5e588c6 # Parent 53e7a4b34028325a4be3a603f5ff15d402451f8a Fix an assertion failure/unlikely crash when: 1. Open a purple_notify_formatted() dialog, such as the QQ about window or the AIM "who am I waiting on authorization from?" dialog 2. Close the dialog with the close button 3. Sign off the account The problem is that the dialog was closed, but it was not removed from the list of open dialogs. So purple_notify_close_with_handle() tried to close it again. diff -r 53e7a4b34028 -r 9b61b1088dfb pidgin/gtknotify.c --- a/pidgin/gtknotify.c Fri Nov 14 20:46:35 2008 +0000 +++ b/pidgin/gtknotify.c Fri Nov 14 21:46:39 2008 +0000 @@ -703,7 +703,7 @@ gtk_widget_grab_focus(button); g_signal_connect_swapped(G_OBJECT(button), "clicked", - G_CALLBACK(gtk_widget_destroy), window); + G_CALLBACK(formatted_close_cb), window); g_signal_connect(G_OBJECT(window), "key_press_event", G_CALLBACK(formatted_input_cb), NULL);