# HG changeset patch # User Paul Aurich # Date 1250227224 0 # Node ID a40e0b43f57f9a46fb95504408c1f6afc1de02d9 # Parent 2b9da4c0c47b4c39dca3e71e6184d1b2be890591 This is annoying, but am I actually missing anything? diff -r 2b9da4c0c47b -r a40e0b43f57f libpurple/protocols/jabber/caps.c --- a/libpurple/protocols/jabber/caps.c Fri Aug 14 01:34:27 2009 +0000 +++ b/libpurple/protocols/jabber/caps.c Fri Aug 14 05:20:24 2009 +0000 @@ -456,6 +456,11 @@ /* Only validate if these are v1.5 capabilities */ if (userdata->hash) { gchar *hash = NULL; + /* + * TODO: If you add *any* hash here, make sure the checksum buffer + * size in jabber_caps_calculate_hash is large enough. The cipher API + * doesn't seem to offer a "Get the hash size" function(?). + */ if (!strcmp(userdata->hash, "sha-1")) { hash = jabber_caps_calculate_hash(info, "sha1"); } else if (!strcmp(userdata->hash, "md5")) {