# HG changeset patch
# User Luke Schierer <lschiere@pidgin.im>
# Date 1036361799 0
# Node ID a611ec77d1d21f7c71324747b57abc2b330c0111
# Parent  271ca53950e633d9b8b997e58a2578f911728a96
[gaim-migrate @ 4043]
this is a better test condition from paco-paco.
(17:05:42) Paco-Paco: and you have to check the return value of wait against (pid_t)-1
(17:05:42) Paco-Paco: you *cannot* use < 0
(17:05:45) Paco-Paco: pid_t is unsigned on some systems :-)
(17:05:57) Paco-Paco: actually, my patch might need fixed for the while loop
(17:05:58) ***Paco-Paco looks
(17:07:16) Paco-Paco: LSchiere: actually, I have a one-line fix

committer: Tailor Script <tailor@pidgin.im>

diff -r 271ca53950e6 -r a611ec77d1d2 .todo
--- a/.todo	Sun Nov 03 21:59:05 2002 +0000
+++ b/.todo	Sun Nov 03 22:16:39 2002 +0000
@@ -1,4 +1,4 @@
-<!-- Automagically generated by the ToDo program on Sun Nov  3 12:58:11 2002 -->
+<!-- Automagically generated by the ToDo program on Sun Nov  3 17:10:28 2002 -->
 <todo version="0.1.14">
     <note priority="verylow" time="1036026433">
         DISCUSSION: entries here are things i'm not sure are desirable or doable.
@@ -191,6 +191,18 @@
         <note priority="low" time="1036346291">
             blist short cuts apparently not working
         </note>
+        <note priority="medium" time="1036361367">
+            do not automatically resize windows that have been manually resized.
+            <note priority="medium" time="1036361397">
+                when a buddy icon is recieved
+            </note>
+            <note priority="medium" time="1036361407">
+                when an im image is recieved
+            </note>
+            <note priority="medium" time="1036361428">
+                when a new tab is created
+            </note>
+        </note>
     </note>
     <note priority="high" time="1036029923">
         Prefs stuff
diff -r 271ca53950e6 -r a611ec77d1d2 TODO
--- a/TODO	Sun Nov 03 21:59:05 2002 +0000
+++ b/TODO	Sun Nov 03 22:16:39 2002 +0000
@@ -8,6 +8,8 @@
 	sounds while away?	
 
 gtk2/new prefs
+	when a conversation has been manually resized, it should not be 
+		resized to the default on: 1)buddy icon. 2)im image 3)new tab
 	blist shortcuts apparently not working
 	better gtk2-ified icons: maybe a send icon? review the ones we're using now. do they make sense?
 	sound player preference not being saved
diff -r 271ca53950e6 -r a611ec77d1d2 src/util.c
--- a/src/util.c	Sun Nov 03 21:59:05 2002 +0000
+++ b/src/util.c	Sun Nov 03 22:16:39 2002 +0000
@@ -650,7 +650,7 @@
 
 	do {
 		pid = waitpid(-1, &status, WNOHANG);
-	} while (pid > 0);
+	} while (pid != 0 && pid != (pid_t)-1);
 	if(pid == (pid_t)-1 && errno != ECHILD) {
 		char errmsg[BUFSIZ];
 		sprintf(errmsg, "Warning: waitpid() returned %d", pid);