# HG changeset patch # User Sadrul Habib Chowdhury # Date 1220616457 0 # Node ID ac3db6ba7078669aa79dd6aeb1c3543211b89987 # Parent de712dc6fecdf091db119c9cbb8b52f02b4bd7b8 Fix the conversation window closing unexpectedly. Again. Fixes #4442. diff -r de712dc6fecd -r ac3db6ba7078 pidgin/gtkconv.c --- a/pidgin/gtkconv.c Fri Sep 05 09:30:00 2008 +0000 +++ b/pidgin/gtkconv.c Fri Sep 05 12:07:37 2008 +0000 @@ -5253,8 +5253,7 @@ if (conv && PIDGIN_IS_PIDGIN_CONVERSATION(conv) && !hide) { PidginConversation *gtkconv = PIDGIN_CONVERSATION(conv); if (gtkconv->win == hidden_convwin) { - pidgin_conv_window_remove_gtkconv(gtkconv->win, gtkconv); - pidgin_conv_placement_place(gtkconv); + pidgin_conv_attach_to_conversation(gtkconv->active_conv); } return; } @@ -7239,8 +7238,7 @@ if (!l) break; - pidgin_conv_window_remove_gtkconv(hidden_convwin, gtkconv); - pidgin_conv_placement_place(gtkconv); + pidgin_conv_attach_to_conversation(conv); /* TODO: do we need to do anything for any other conversations that are in the same gtkconv here? * I'm a little concerned that not doing so will cause the "pending" indicator in the gtkblist not to be cleared. -DAA*/ @@ -7280,8 +7278,7 @@ purple_conversation_get_account(conv))))) continue; - pidgin_conv_window_remove_gtkconv(hidden_convwin, gtkconv); - pidgin_conv_placement_place(gtkconv); + pidgin_conv_attach_to_conversation(conv); } }