# HG changeset patch # User Elliott Sales de Andrade # Date 1290322725 0 # Node ID ad11780ba8b950c52c0d6b121e579408927d74b6 # Parent dec85cefc758637751be84a0a381564ddefd3e61 Prevent a use-after-free. The timeout_cb may free the MsnTransaction, so we can't use it after that. diff -r dec85cefc758 -r ad11780ba8b9 libpurple/protocols/msn/transaction.c --- a/libpurple/protocols/msn/transaction.c Sun Nov 21 00:53:26 2010 +0000 +++ b/libpurple/protocols/msn/transaction.c Sun Nov 21 06:58:45 2010 +0000 @@ -220,10 +220,11 @@ purple_debug_info("msn", "timed out: %s %d %s\n", trans->command, trans->trId, trans->params); #endif + trans->timer = 0; + if (trans->timeout_cb != NULL) trans->timeout_cb(trans->cmdproc, trans); - trans->timer = 0; return FALSE; }