# HG changeset patch
# User Mark Doliner <mark@kingant.net>
# Date 1145334354 0
# Node ID ad83024934edcb388f64319d5b2f9a22704f1f4d
# Parent  a07dcc2c01bda9af4306298b4e4b2fdde7735576
[gaim-migrate @ 16055]
Fix Coverity CID 86: Malformed incoming IMs could cause a double-free.
I don't think this will ever happen because the oscar servers filter
malformed SNACs.

committer: Tailor Script <tailor@pidgin.im>

diff -r a07dcc2c01bd -r ad83024934ed src/protocols/oscar/family_icbm.c
--- a/src/protocols/oscar/family_icbm.c	Tue Apr 18 04:03:18 2006 +0000
+++ b/src/protocols/oscar/family_icbm.c	Tue Apr 18 04:25:54 2006 +0000
@@ -1679,13 +1679,13 @@
 
 		} else if (type == 0x0017) {
 
-			free(args.extdata);
-			args.extdatalen = length;
-			if (args.extdatalen > byte_stream_empty(bs))
+			if (length > byte_stream_empty(bs))
 			{
 				gaim_debug_misc("oscar", "Received an IM containing an invalid message part from %s.  They are probably trying to do something malicious.\n", userinfo->sn);
 				break;
 			}
+			free(args.extdata);
+			args.extdatalen = length;
 			if (args.extdatalen == 0)
 				args.extdata = NULL;
 			else