# HG changeset patch # User Mark Doliner # Date 1250121681 0 # Node ID b59aa0c36b2b86c0bc8777413d5e153f7e13d456 # Parent de7f6fd04298e8ceea581652f3254b4bd46abcf4 Ignore unknown MySpace messages instead of trying to treat them like normal IMs. This can cause problems if MySpace ever sends an uknown message type and we try to treat it as an IM. diff -r de7f6fd04298 -r b59aa0c36b2b libpurple/protocols/myspace/myspace.c --- a/libpurple/protocols/myspace/myspace.c Wed Aug 12 23:13:47 2009 +0000 +++ b/libpurple/protocols/myspace/myspace.c Thu Aug 13 00:01:21 2009 +0000 @@ -1693,10 +1693,16 @@ case MSIM_BM_UNOFFICIAL_CLIENT: return msim_incoming_unofficial_client(session, msg); default: - /* Not really an IM, but show it for informational - * purposes during development. */ - /* TODO: This is probably wrong */ - return msim_incoming_action_or_im(session, msg); + /* + * Unknown message type! We used to call + * msim_incoming_action_or_im(session, msg); + * for these, but that doesn't help anything, and it means + * we'll show broken gibberish if MySpace starts sending us + * other message types. + */ + purple_debug_warning("myspace", "Received unknown imcoming " + "message, bm=%u\n", bm); + return TRUE; } }