# HG changeset patch
# User Daniel Atallah <daniel.atallah@gmail.com>
# Date 1164087175 0
# Node ID c3b0f09247739a8c8ff55ca66e1221f762eaf100
# Parent  40364ce5d6e36c36ed6dfa6a224ebcc82414986e
[gaim-migrate @ 17800]
We shouldn't be freeing kvp->value, which is put in the list store as G_TYPE_POINTER.
This was causing crashes for people editing SILC accounts (nothing else uses GAIM_PREF_STRING_LIST).

committer: Tailor Script <tailor@pidgin.im>

diff -r 40364ce5d6e3 -r c3b0f0924773 gtk/gtkaccount.c
--- a/gtk/gtkaccount.c	Tue Nov 21 04:34:38 2006 +0000
+++ b/gtk/gtkaccount.c	Tue Nov 21 05:32:55 2006 +0000
@@ -810,7 +810,7 @@
 					if (node->data != NULL) {
 						kvp = (GaimKeyValuePair *) node->data;
 						if ((kvp->value != NULL) && (str_value != NULL) &&
-							!g_utf8_collate(kvp->value, str_value))
+						    !g_utf8_collate(kvp->value, str_value))
 							idx = i;
 
 						gtk_list_store_append(model, &iter);
@@ -1247,7 +1247,6 @@
 					gtk_combo_box_get_active_iter(GTK_COMBO_BOX(widget), &iter);
 					gtk_tree_model_get(gtk_combo_box_get_model(GTK_COMBO_BOX(widget)), &iter, 1, &value2, -1);
 					gaim_account_set_string(account, setting, value2);
-					g_free(value2);
 					break;
 
 				default: