# HG changeset patch # User Mark Doliner # Date 1200556383 0 # Node ID c69f472ff6835ba29daa9b743cb5fa7944710216 # Parent 8d01e41786ce4992687cde80b1f50c8a7eb07fd7 Apparently gcc gives a warning here even though it's perfectly valid and more efficient. diff -r 8d01e41786ce -r c69f472ff683 libpurple/protocols/oscar/oscar.c --- a/libpurple/protocols/oscar/oscar.c Thu Jan 17 07:39:25 2008 +0000 +++ b/libpurple/protocols/oscar/oscar.c Thu Jan 17 07:53:03 2008 +0000 @@ -1789,11 +1789,7 @@ purple_prpl_got_user_status_deactive(account, info->sn, OSCAR_STATUS_ID_MOBILE); } - /* - * It's ok for us to use == instead of strcmp() here because - * status_id is set to one of these #defines a few lines above here. - */ - if (status_id == OSCAR_STATUS_ID_AVAILABLE) + if (strcmp(status_id, OSCAR_STATUS_ID_AVAILABLE) == 0) { char *message = NULL; char *itmsurl = NULL;