# HG changeset patch # User Richard Laager # Date 1176620203 0 # Node ID d3e197b67ef9187efd2c4a4b88620818a6fd60d4 # Parent bd4a21db0ec9adad267f4c90baf1456bdccf8bdf Fix Ticket #152 "The string gchar *errmsg = g_strconcat(_("Setting custom faces is not currently supported. Please choose an image from "), buddy_icon_dir, ".", NULL); assumes that it is always grammatically correct to append a directory name to a sentence fragment. Also, without reading the source, the translator would not have an idea what the sentence fragment is talking about." diff -r bd4a21db0ec9 -r d3e197b67ef9 libpurple/protocols/qq/buddy_info.c --- a/libpurple/protocols/qq/buddy_info.c Sun Apr 15 01:26:57 2007 +0000 +++ b/libpurple/protocols/qq/buddy_info.c Sun Apr 15 06:56:43 2007 +0000 @@ -562,7 +562,7 @@ gint prefix_len = strlen(QQ_ICON_PREFIX); gint suffix_len = strlen(QQ_ICON_SUFFIX); gint dir_len = strlen(buddy_icon_dir); - gchar *errmsg = g_strconcat(_("Setting custom faces is not currently supported. Please choose an image from "), buddy_icon_dir, ".", NULL); + gchar *errmsg = g_strdup_printf(_("Setting custom faces is not currently supported. Please choose an image from %s."), buddy_icon_dir); gboolean icon_global = purple_account_get_bool(gc->account, "use-global-buddyicon", TRUE); if (!icon_path)