# HG changeset patch
# User Ka-Hing Cheung <khc@hxbc.us>
# Date 1204527834 0
# Node ID dfe4a3e3336a9067baa8e63b801c3e1ca173d38f
# Parent  fa7ddf4b2e0a9b067740c26d0c2bb8c6582a5c82
serv_got_joined_chat() emits "chat-joined" but it also calls
purple_conversation_new() which emits "conversation-created", so attaching
to both signals would make create_conv and attach_signals to be called twice,
leaking the list of signal ids:

==30871== 67 (43 direct, 24 indirect) bytes in 3 blocks are definitely lost in loss record 94 of 265
==30871==    at 0x4006A6E: malloc (vg_replace_malloc.c:207)
==30871==    by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6)
==30871==    by 0xA31B3A: g_slice_alloc (in /lib/libglib-2.0.so.0.1400.6)
==30871==    by 0xA32D9A: g_slist_append (in /lib/libglib-2.0.so.0.1400.6)
==30871==    by 0x4F1CA4A: attach_signals (notify.c:321)
==30871==    by 0x4F1CDCA: conv_created (notify.c:388)

Credit goes to Andrew Gaul for sending me this valgrind trace, blame me if
this breaks anything.

diff -r fa7ddf4b2e0a -r dfe4a3e3336a pidgin/plugins/notify.c
--- a/pidgin/plugins/notify.c	Sun Mar 02 22:35:56 2008 +0000
+++ b/pidgin/plugins/notify.c	Mon Mar 03 07:03:54 2008 +0000
@@ -842,8 +842,6 @@
 	                    PURPLE_CALLBACK(chat_sent_im), NULL);
 	purple_signal_connect(conv_handle, "conversation-created", plugin,
 	                    PURPLE_CALLBACK(conv_created), NULL);
-	purple_signal_connect(conv_handle, "chat-joined", plugin,
-	                    PURPLE_CALLBACK(conv_created), NULL);
 	purple_signal_connect(conv_handle, "deleting-conversation", plugin,
 	                    PURPLE_CALLBACK(deleting_conv), NULL);
 #if 0