# HG changeset patch
# User Richard Laager <rlaager@wiktel.com>
# Date 1135339321 0
# Node ID e0e8b0735c5a093c21369574fc55a9958f29d271
# Parent  de306144dc8a2dd8c8e0744f2c73dd0939a10c92
[gaim-migrate @ 14977]
A change from Bartosz Oler. I think this is intended to hide blocked as a status that one can set on themself. Anyway, this is all wrong, so I added some comments to that effect.

committer: Tailor Script <tailor@pidgin.im>

diff -r de306144dc8a -r e0e8b0735c5a src/protocols/gg/gg.c
--- a/src/protocols/gg/gg.c	Fri Dec 23 06:48:27 2005 +0000
+++ b/src/protocols/gg/gg.c	Fri Dec 23 12:02:01 2005 +0000
@@ -1452,9 +1452,10 @@
 			NULL);
 	types = g_list_append(types, type);
 
-	/* Why is blocked a status??? -- rlaager */
+	/* This status is wrong.  It shouldn't exist.  This prpl must not be
+	 * using the privacy stuff correctly. -- rlaager */
 	type = gaim_status_type_new_with_attrs(
-			GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, TRUE, FALSE,
+			GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, FALSE, FALSE,
 			"message", _("Message"), gaim_value_new(GAIM_TYPE_STRING), NULL);
 	types = g_list_append(types, type);
 
@@ -1475,6 +1476,9 @@
 					 ggp_bmenu_add_to_chat, NULL, NULL);
 	m = g_list_append(m, act);
 
+	/* Using a blist node boolean here is also wrong.
+	 * Once the Block and Unblock actions are added to the core,
+	 * this will have to go. -- rlaager */
 	if (gaim_blist_node_get_bool(node, "blocked")) {
 		act = gaim_blist_node_action_new(_("Unblock"),
 						 ggp_bmenu_block, NULL, NULL);