# HG changeset patch # User Eric Warmenhoven # Date 959668592 0 # Node ID e606585a38bd046d5632cdfaf528474e8e0378ca # Parent 501e09c51cbc8337572e4bfbec32f4a50e8c8209 [gaim-migrate @ 290] I can't even remember what i did. committer: Tailor Script diff -r 501e09c51cbc -r e606585a38bd libfaim/CHANGES.gaim --- a/libfaim/CHANGES.gaim Mon May 29 20:30:48 2000 +0000 +++ b/libfaim/CHANGES.gaim Tue May 30 06:36:32 2000 +0000 @@ -1,3 +1,18 @@ + +Tue May 30 04:04:40 UTC 2000 EWarmenhoven + - Well, after trying to screw around with the permit/deny stuff a bit, + I finally decided that having a permit list was for people who didn't + want AIM in the first place. Therefore, I only need to implement the + deny list. This made things work much better. I'm declaring the deny + list as working. + - Chat isn't working, and hasn't for a while. I don't know why; I've + been playing with it for a few days now without much luck. I finally + decided it was time to move it to the UNSUPPORTED section in the + README.gaim file. I actually got it to work once; I don't know how. + - Oscar support in gaim (since I started working on it) is now 10 days + old, and already I've had more than 5 people (not counting Rob) ask + me about it; one person even filed bugs against it. I'm not sure if + that's a good thing or not. Mon May 29 20:24:24 UTC 2000 EWarmenhoven - Updated the libfaim code to the latest that's in libfaim's CVS. The diff -r 501e09c51cbc -r e606585a38bd libfaim/README.gaim --- a/libfaim/README.gaim Mon May 29 20:30:48 2000 +0000 +++ b/libfaim/README.gaim Tue May 30 06:36:32 2000 +0000 @@ -29,33 +29,28 @@ Being away/coming back Setting your info Getting users' info +Getting users' away messages (PLEASE do not use oscar/libfaim just because of + this, gaim with libfaim is still really buggy, none of you will listen + to me anyway) +Telling the server who's on your permit/deny lists + +CURRENTLY UNSUPPORTED FEATURES +============================== +Warning users/getting warned Chat: - joining rooms - leaving rooms - talking - getting invited - inviting someone -Getting users' away messages (PLEASE do not use oscar/libfaim just because of - this, gaim with libfaim is still really buggy, none of you will listen - to me anyway) - -CURRENTLY UNSUPPORTED FEATURES -============================== -Warning users/getting warned -Chat: - - whispering + - whispering (this will never happen) - refreshing the chatlist in the preferences dialog Getting/setting dir info Changing your password File transfer/IM images/voice chat/etc. -Telling the server who's on your permit/deny lists KNOWN ISSUES ============ -- The permit/deny stuff is really funny. If I don't put it there, everything -works great, if I do, it occasionally works, but not well. I've commented it out -(again - I swear, this is the most on-again-off-again feature). - - Oscar doesn't do whispering in chat rooms any more (and hasn't for quite a while, evidently). So if you want to "whisper" to someone, just IM them. @@ -63,6 +58,23 @@ want to know. I'm not worried about it, I never use chat. It's not exactly high- priority. +- Gaim/TOC can do file transfers, but Gaim/Faim cannot. This is not because +there is any difference in the two protocols as far as the actual transfer is +concerned. The only thing preventing this is it is currently not possible to +recognize when we've received a file transfer request using libfaim. Once +libfaim can tell us that we've received the request, the only thing we should +need to change is to have oscar.c wait for one of those notifications and then +call accept_file_transfer() from rvous.c. No modification of rvous.c should be +necessary at that point. (The same should apply to IM Images and Voice Chat and +all the other RVOUS stuff - they are all protocol-independent.) + +- What *is* protocol-dependent about the RVOUS stuff is that only Oscar can +request RVOUS actions, though both can receive them. However, libfaim cannot +yet make the requests, so there is no difference between Gaim/TOC and Gaim/Faim +there. + +- Warnings and Dir Info are not in libfaim yet, and so are not in Gaim/Faim yet. + - There are also FIXME's scattered about oscar.c. Grep around for those, figure out what needs to be fixed, do that sort of thing. :) (Fixing the things listed in KNOWN ISSUES above, or any other bugs you happen to find, is a very good use diff -r 501e09c51cbc -r e606585a38bd src/server.c --- a/src/server.c Mon May 29 20:30:48 2000 +0000 +++ b/src/server.c Tue May 30 06:36:32 2000 +0000 @@ -344,11 +344,11 @@ void serv_set_permit_deny() { -#ifndef USE_OSCAR char buf[MSG_LEN]; int at; GList *list; +#ifndef USE_OSCAR /* FIXME! We flash here. */ if (permdeny == 1 || permdeny == 3) { g_snprintf(buf, sizeof(buf), "toc_add_permit"); @@ -379,26 +379,14 @@ #else /* oscar requires us to do everyone at once (?) */ /* I think this code is OK now. */ - /* FIXME : I changed my mind - if (!(permdeny == 1 || permdeny == 4)) { - list = permit; at = 0; - while (list) { - at += g_snprintf(&buf[at], sizeof(buf) - at, "%s&", list->data); - list = list->next; - } - aim_bos_changevisibility(gaim_sess, gaim_conn, - AIM_VISIBILITYCHANGE_PERMITADD, buf); - } else { - list = deny; at = 0; - if (list == NULL) return; - while (list) { - at += g_snprintf(&buf[at], sizeof(buf) - at, "%s&", list->data); - list = list->next; - } - aim_bos_changevisibility(gaim_sess, gaim_conn, + list = deny; at = 0; + if (list == NULL) return; + while (list) { + at += g_snprintf(&buf[at], sizeof(buf) - at, "%s&", list->data); + list = list->next; + } + aim_bos_changevisibility(gaim_sess, gaim_conn, AIM_VISIBILITYCHANGE_DENYADD, buf); - } - */ #endif }