# HG changeset patch # User Mike Ruprecht # Date 1220342644 0 # Node ID ef161c8f14dfb5ecbe4f6faab8be1505408be85e # Parent e8b8c6b141960eeef069e04f75b562b2556df6f5 Send and receive optional codec parameters in Jingle RTP. diff -r e8b8c6b14196 -r ef161c8f14df libpurple/protocols/jabber/jingle.c --- a/libpurple/protocols/jabber/jingle.c Mon Sep 01 03:18:26 2008 +0000 +++ b/libpurple/protocols/jabber/jingle.c Tue Sep 02 08:04:04 2008 +0000 @@ -312,6 +312,8 @@ for (codec_element = xmlnode_get_child(description, "payload-type") ; codec_element ; codec_element = xmlnode_get_next_twin(codec_element)) { + xmlnode *param; + gchar *codec_str; encoding_name = xmlnode_get_attrib(codec_element, "name"); id = xmlnode_get_attrib(codec_element, "id"); @@ -320,10 +322,18 @@ codec = fs_codec_new(atoi(id), encoding_name, type, clock_rate ? atoi(clock_rate) : 0); - purple_debug_info("jingle", "codec: %i, %s, %s, %i\n", codec->id, - codec->encoding_name, codec->media_type == FS_MEDIA_TYPE_AUDIO ? - "FS_MEDIA_TYPE_AUDIO" : codec->media_type == FS_MEDIA_TYPE_VIDEO ? - "FS_MEDIA_TYPE_VIDEO" : "FS_MEDIA_TYPE_NONE", codec->clock_rate); + + for (param = xmlnode_get_child(codec_element, "parameter"); + param; param = xmlnode_get_next_twin(param)) { + fs_codec_add_optional_parameter(codec, + xmlnode_get_attrib(param, "name"), + xmlnode_get_attrib(param, "value")); + } + + codec_str = fs_codec_to_string(codec); + purple_debug_fatal("jingle", "received codec: %s\n", codec_str); + g_free(codec_str); + codecs = g_list_append(codecs, codec); } return codecs; @@ -445,7 +455,9 @@ { for (; codecs ; codecs = codecs->next) { FsCodec *codec = (FsCodec*)codecs->data; + GList *iter = codec->optional_params; char id[8], clockrate[10], channels[10]; + gchar *codec_str; xmlnode *payload = xmlnode_new_child(description, "payload-type"); g_snprintf(id, sizeof(id), "%d", codec->id); @@ -456,6 +468,17 @@ xmlnode_set_attrib(payload, "id", id); xmlnode_set_attrib(payload, "clockrate", clockrate); xmlnode_set_attrib(payload, "channels", channels); + + for (; iter; iter = g_list_next(iter)) { + FsCodecParameter *fsparam = iter->data; + xmlnode *param = xmlnode_new_child(payload, "parameter"); + xmlnode_set_attrib(param, "name", fsparam->name); + xmlnode_set_attrib(param, "value", fsparam->value); + } + + codec_str = fs_codec_to_string(codec); + purple_debug_fatal("jingle", "adding codec: %s\n", codec_str); + g_free(codec_str); } }