# HG changeset patch # User Richard Laager # Date 1177805367 0 # Node ID f130f097e378257f4768fffb51cf2a639945bffb # Parent 60aae7ef3b7ede4a37009f7fc508e66edff9347a 19:00:43 Ka-Hing Cheung (khc): rlaager: shouldn't we give g_free as the key free function for icon_data_cache? 19:01:12 Ka-Hing Cheung (khc): valgrind is complaining that we are leaking the keys diff -r 60aae7ef3b7e -r f130f097e378 libpurple/buddyicon.c --- a/libpurple/buddyicon.c Sun Apr 29 00:09:42 2007 +0000 +++ b/libpurple/buddyicon.c Sun Apr 29 00:09:27 2007 +0000 @@ -1124,7 +1124,8 @@ g_direct_hash, g_direct_equal, NULL, (GFreeFunc)g_hash_table_destroy); - icon_data_cache = g_hash_table_new(g_str_hash, g_str_equal); + icon_data_cache = g_hash_table_new_full(g_str_hash, g_str_equal, + g_free, NULL); icon_file_cache = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, NULL); pointer_icon_cache = g_hash_table_new(g_direct_hash, g_direct_equal);