# HG changeset patch # User andrew.victor@mxit.com # Date 1259069905 0 # Node ID f261b4978ae4e5316fb778e100a25f3b55c84ca7 # Parent 06fabb28bc69114f8d9fa7e105b4a02ca558ad0d If Pidgin is running in Debug mode, on Windows, and no splash-screen is active then a segfault may occur. diff -r 06fabb28bc69 -r f261b4978ae4 libpurple/protocols/mxit/splashscreen.c --- a/libpurple/protocols/mxit/splashscreen.c Tue Nov 24 13:23:27 2009 +0000 +++ b/libpurple/protocols/mxit/splashscreen.c Tue Nov 24 13:38:25 2009 +0000 @@ -43,10 +43,10 @@ { const char* splashId = purple_account_get_string(session->acc, MXIT_CONFIG_SPLASHID, NULL); - purple_debug_info(MXIT_PLUGIN_ID, "Current splashId: '%s'\n", splashId); - - if ((splashId != NULL) && (*splashId != '\0')) + if ((splashId != NULL) && (*splashId != '\0')) { + purple_debug_info(MXIT_PLUGIN_ID, "Current splashId: '%s'\n", splashId); return splashId; + } else return NULL; } @@ -149,7 +149,7 @@ /* Get current splash ID */ splashId = splash_current(session); - if (!splashId) + if (splashId == NULL) /* no splash-screen */ return; /* if is clickable, then send click event */