Mercurial > pidgin

changeset 19496:004c3e257bd0

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
- Even more TODO whacking - Replace a strcmp with a check_subject_name
author William Ehlhardt <williamehlhardt@gmail.com>
date Mon, 20 Aug 2007 16:22:35 +0000
parents 5aaff16e9fbb
children d351a42435a9
files libpurple/certificate.c
diffstat 1 files changed, 1 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/certificate.c	Mon Aug 20 03:53:28 2007 +0000
+++ b/libpurple/certificate.c	Mon Aug 20 16:22:35 2007 +0000
@@ -432,7 +432,6 @@
 	g_return_val_if_fail(id, FALSE);
 	g_return_val_if_fail(pool->put_cert, FALSE);
 
-	/* TODO: Should this just be someone else's problem? */
 	/* Whether crt->scheme matches find_scheme(pool->scheme_name) is not
 	   relevant... I think... */
 	g_return_val_if_fail(
@@ -539,8 +538,7 @@
 	cn = purple_certificate_get_subject_name(crt);
 
 	/* Determine whether the name matches */
-	/* TODO: Worry about strcmp safety? */
-	if (!strcmp(cn, vrq->subject_name)) {
+	if (purple_certificate_check_subject_name(crt, vrq->subject_name)) {
 		cn_match = _("");
 	} else {
 		cn_match = _("(DOES NOT MATCH)");