Mercurial > pidgin

changeset 26181:00c659e55902

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add a note that this function could potentially be faster.
author Mark Doliner <mark@kingant.net>
date Fri, 13 Mar 2009 02:51:00 +0000
parents 413b445a6018
children 246e66ca3a4d 2321248ad702
files libpurple/util.c
diffstat 1 files changed, 6 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/util.c	Fri Mar 13 02:21:27 2009 +0000
+++ b/libpurple/util.c	Fri Mar 13 02:51:00 2009 +0000
@@ -2850,6 +2850,12 @@
 	return "icon";
 }
 
+/*
+ * TODO: Consider using something faster than SHA-1, such as MD5, MD4
+ *       or CRC32.  Are there security implications to that?  Would
+ *       probably be a good idea to benchmark some algorithms with
+ *       3KB-10KB chunks of data (typical buddy icon sizes).
+ */
 char *
 purple_util_get_image_checksum(gconstpointer image_data, size_t image_len)
 {