Mercurial > pidgin

changeset 21833:068b412ba385

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
part of the series of patches from QuLogic that fixes a use-after-free, References #4382
author Ka-Hing Cheung <khc@hxbc.us>
date Sun, 16 Dec 2007 00:34:21 +0000
parents 8d5989d932c9
children e552f16abc88
files libpurple/protocols/msn/contact.c
diffstat 1 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/msn/contact.c	Sat Dec 15 20:29:56 2007 +0000
+++ b/libpurple/protocols/msn/contact.c	Sun Dec 16 00:34:21 2007 +0000
@@ -1289,16 +1289,16 @@
 				purple_debug_info("MSNCL", "Adding group %s with guid = %s to the userlist\n", state->new_group_name, guid);
 				msn_group_new(session->userlist, guid, state->new_group_name);
 
-				g_free(guid);
-
 				if (state->action & MSN_ADD_BUDDY) {
 					msn_userlist_add_buddy(session->userlist,
 						state->who,
 						state->new_group_name);
 				} else if (state->action & MSN_MOVE_BUDDY) {
 					msn_add_contact_to_group(session->contact, state, state->who, guid); 
+					g_free(guid);
 					return;
 				}
+				g_free(guid);
 			} else {
 				purple_debug_info("MSNCL", "Adding group %s failed\n",
 					state->new_group_name);